WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76030
ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorCPP.pm should be the same
https://bugs.webkit.org/show_bug.cgi?id=76030
Summary
ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorC...
Kentaro Hara
Reported
2012-01-10 22:53:22 PST
The conditions under which 1 is returned by ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() are messy. We should clean up the conditions. This is a refactoring for implementing the [Supplemental] IDL for custom methods.
Attachments
Patch
(6.54 KB, patch)
2012-01-10 23:25 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-01-10 23:25:58 PST
Created
attachment 121982
[details]
Patch
WebKit Review Bot
Comment 2
2012-01-11 02:25:09 PST
Comment on
attachment 121982
[details]
Patch Clearing flags on attachment: 121982 Committed
r104690
: <
http://trac.webkit.org/changeset/104690
>
WebKit Review Bot
Comment 3
2012-01-11 02:25:19 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug