RESOLVED FIXED145154
[EFL] Use GSimpleProxyResolver instead of custom SoupProxyResolver 
https://bugs.webkit.org/show_bug.cgi?id=145154
Summary [EFL] Use GSimpleProxyResolver instead of custom SoupProxyResolver
Ryuan Choi
Reported 2015-05-18 17:15:09 PDT
SoupProxyResolver was deprecated since 2.28 Now, we are using libsoup 2.42
Attachments
Patch (16.61 KB, patch)
2015-05-18 17:21 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (19.98 KB, patch)
2015-05-18 23:34 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (19.77 KB, patch)
2015-05-18 23:35 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (19.70 KB, patch)
2015-05-19 17:52 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-05-18 17:21:25 PDT
Created attachment 253355 [details] Patch
Gyuyoung Kim
Comment 2 2015-05-18 18:17:28 PDT
Comment on attachment 253355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review > Source/WebCore/ChangeLog:15 > + * platform/network/soup/ProxyResolverSoup.cpp: Removed. Doesn't Win port still use this file ? Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
Ryuan Choi
Comment 3 2015-05-18 23:34:05 PDT
Created attachment 253372 [details] Patch
Ryuan Choi
Comment 4 2015-05-18 23:35:50 PDT
Created attachment 253373 [details] Patch
Csaba Osztrogonác
Comment 5 2015-05-18 23:39:35 PDT
Comment on attachment 253355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253355&action=review >> Source/WebCore/ChangeLog:15 >> + * platform/network/soup/ProxyResolverSoup.cpp: Removed. > > Doesn't Win port still use this file ? > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj I think nor Apple Windows, neither WinCairo port used SOUP ever, but there was an experiment to do it 2 years before - https://trac.webkit.org/changeset/166506 . But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I right?
Ryuan Choi
Comment 6 2015-05-19 17:47:48 PDT
(In reply to comment #5) > Comment on attachment 253355 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253355&action=review > > >> Source/WebCore/ChangeLog:15 > >> + * platform/network/soup/ProxyResolverSoup.cpp: Removed. > > > > Doesn't Win port still use this file ? > > > > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj > > I think nor Apple Windows, neither WinCairo port used SOUP ever, but there > was an experiment to do it 2 years before - > https://trac.webkit.org/changeset/166506 . > But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I > right? Although windows port have a plan to use SOUP, I don't think that ProxyResolverSoup.cpp is required anymore because WebCore.vcxproj still contains SoupNetworkSession.cpp which covers the functionality of ProxyResolverSoup in this patch.
Ryuan Choi
Comment 7 2015-05-19 17:52:15 PDT
Created attachment 253413 [details] Patch
Alex Christensen
Comment 8 2015-05-19 18:07:24 PDT
(In reply to comment #5) > I think nor Apple Windows, neither WinCairo port used SOUP ever, but there > was an experiment to do it 2 years before - > https://trac.webkit.org/changeset/166506 . > But it seems there is no plan to use SOUP on Windows nowadays. Alex, am I > right? I'm pretty sure I'm the only one who has ever experimented with SOUP on Windows. GStreamer on Windows uses libsoup, but they used a version that was too old to link with WebKit, and I never got it to actually load anything. I think it could be done, but that should not affect decisions in WebKit right now. The WinCairo port uses CURL because of its license IIRC
Gyuyoung Kim
Comment 9 2015-05-19 18:34:40 PDT
Comment on attachment 253413 [details] Patch Thank Alex, r=me.
Ryuan Choi
Comment 10 2015-05-19 18:57:20 PDT
Comment on attachment 253413 [details] Patch Thanks.
WebKit Commit Bot
Comment 11 2015-05-19 19:46:51 PDT
Comment on attachment 253413 [details] Patch Clearing flags on attachment: 253413 Committed r184610: <http://trac.webkit.org/changeset/184610>
WebKit Commit Bot
Comment 12 2015-05-19 19:46:57 PDT
All reviewed patches have been landed. Closing bug.
Ryuan Choi
Comment 13 2015-05-19 21:50:38 PDT
*** Bug 113587 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.