Bug 98753

Summary: Change PeerConnection getStats function to single value local / remote
Product: WebKit Reporter: Harald Alvestrand <hta>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, ojan, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Harald Alvestrand
Reported 2012-10-09 04:52:33 PDT
As landed, PeerConnection draft spec says that the local and remote components of an RTCStatsReport are single RTCStatsElement attributes, not arrays of RTCStatselement (as an earlier draft said) or a function returning a sequence<RTCStatsElement> (as the patch landed). This seems to make sense as a simplification.
Attachments
Patch (15.23 KB, patch)
2012-10-09 05:07 PDT, Harald Alvestrand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Harald Alvestrand
Comment 1 2012-10-09 05:07:26 PDT
Created attachment 167737 [details] Patch
WebKit Review Bot
Comment 2 2012-10-09 05:08:33 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-10-09 08:40:27 PDT
Comment on attachment 167737 [details] Patch That's much simpler.
WebKit Review Bot
Comment 4 2012-10-09 08:56:04 PDT
Comment on attachment 167737 [details] Patch Clearing flags on attachment: 167737 Committed r130768: <http://trac.webkit.org/changeset/130768>
WebKit Review Bot
Comment 5 2012-10-09 08:56:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.