Bug 92474

Summary: DragController should ascertain dragClient to be non-null
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: New BugsAssignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dbates, enrica, sam, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90675    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Vivek Galatage
Reported 2012-07-27 02:10:27 PDT
Page object should ascertain pageClients.dragClient to be non-null
Attachments
Patch (1.43 KB, patch)
2012-07-27 02:13 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.24 KB, patch)
2012-07-27 12:45 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.24 KB, patch)
2012-07-27 12:54 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-07-27 02:13:32 PDT
Created attachment 154882 [details] Patch
Vivek Galatage
Comment 2 2012-07-27 02:23:08 PDT
When enabled(DRAG_SUPPORT), the page object should ascertain pageClients.dragClient to be non-null. Page object goes on creating dragController with the given dragClient. The dragController assumes the dragClient being always available hence all the calls on dragClient are not checking for null value of m_client. So there are two options: 1. If the dragClient is still optional when ENABLE(DRAG_SUPPORT), then we should migrate the creation of dragController from Page::Page() constructor's initialization list inside the constructor body to create the controller only when a non-null dragClient is sent. a-la if (pageClients.dragClient) m_dragController = DragController::create(this, pageClients.dragClient); 2. If this is mandatory when ENABLE(DRAG_SUPPORT), then we can simply put an ASSERT statement in Page::Page(). Please let me know your thoughts on the same.
Vivek Galatage
Comment 3 2012-07-27 12:45:42 PDT
Created attachment 155026 [details] Patch
Tony Chang
Comment 4 2012-07-27 12:48:15 PDT
Comment on attachment 155026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155026&action=review > Source/WebCore/ChangeLog:3 > + Page object should ascertain pageClients.dragClient to be non-null This description is no longer correct. Otherwise, this change seems fine.
Vivek Galatage
Comment 5 2012-07-27 12:54:52 PDT
Created attachment 155029 [details] Patch
WebKit Review Bot
Comment 6 2012-07-27 15:38:00 PDT
Comment on attachment 155029 [details] Patch Clearing flags on attachment: 155029 Committed r123927: <http://trac.webkit.org/changeset/123927>
WebKit Review Bot
Comment 7 2012-07-27 15:38:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.