Bug 91970

Summary:

AuthorShadowDOM for meter element

Product:

WebKit

Reporter:

Shinya Kawanaka <shinyak>

Component:

DOM

Assignee:

Shinya Kawanaka <shinyak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cmarcelo, dglazkov, dominicc, eric, hayato, macpherson, menard, morrita, ojan, tasak, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

93945

Bug Blocks:

82313

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from gce-cr-linux-04	none
Patch	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch for landing	none

Shinya Kawanaka

Reported 2012-07-23 01:03:38 PDT

We would like to support AuthorShadowDOM for meter element.

Attachments
Patch (97.39 KB, patch) 2012-08-07 00:38 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (97.87 KB, patch) 2012-08-07 22:43 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-04 (520.58 KB, application/zip) 2012-08-07 23:39 PDT, WebKit Review Bot	no flags	Details
Patch (98.34 KB, patch) 2012-08-08 02:03 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch for landing (98.41 KB, patch) 2012-08-13 19:08 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch for landing (99.96 KB, patch) 2012-08-14 19:58 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (312.54 KB, application/zip) 2012-08-14 21:47 PDT, WebKit Review Bot	no flags	Details
Patch for landing (99.94 KB, patch) 2012-08-15 00:46 PDT, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2012-08-07 00:38:00 PDT

Created attachment 156887 [details] Patch

Hajime Morrita

Comment 2 2012-08-07 18:35:42 PDT

Comment on attachment 156887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156887&action=review Please consider the theme-based rendering case where WebKit creates only RenderMeter and creates no renderers for shadows. > Source/WebCore/html/shadow/MeterShadowElement.h:52 > +class MeterInnerElement : public MeterShadowElement { Why not inherit directly from HTMLDIvElement?

Shinya Kawanaka

Comment 3 2012-08-07 21:17:09 PDT

(In reply to comment #2) > (From update of attachment 156887 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156887&action=review > > Please consider the theme-based rendering case where WebKit creates only RenderMeter and creates no renderers for shadows. > > > Source/WebCore/html/shadow/MeterShadowElement.h:52 > > +class MeterInnerElement : public MeterShadowElement { > > Why not inherit directly from HTMLDIvElement? Since MeterInnerElement is also an element in UserAgentShadowDOM in <meter> element, it seems natural that MeterInnerElement is derived from MeterShadowElement.

Shinya Kawanaka

Comment 4 2012-08-07 22:43:29 PDT

Created attachment 157119 [details] Patch

WebKit Review Bot

Comment 5 2012-08-07 23:39:03 PDT

Comment on attachment 157119 [details] Patch Attachment 157119 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13446984 New failing tests: fast/dom/HTMLMeterElement/meter-styles.html fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html fast/dom/HTMLMeterElement/meter-writing-mode.html fast/html/meter-user-modify.html fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html fast/dom/shadow/shadowdom-for-meter-without-appearance.html

WebKit Review Bot

Comment 6 2012-08-07 23:39:08 PDT

Created attachment 157128 [details] Archive of layout-test-results from gce-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Shinya Kawanaka

Comment 7 2012-08-08 02:03:08 PDT

Created attachment 157155 [details] Patch

Hajime Morrita

Comment 8 2012-08-13 01:46:46 PDT

Comment on attachment 157155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157155&action=review > Source/WebCore/html/HTMLMeterElement.h:72 > + RenderMeter* renderMeter() const; Please mark them virtual explicitly.

Shinya Kawanaka

Comment 9 2012-08-13 18:55:59 PDT

(In reply to comment #8) > (From update of attachment 157155 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157155&action=review > > > Source/WebCore/html/HTMLMeterElement.h:72 > > + RenderMeter* renderMeter() const; > > Please mark them virtual explicitly. This seems willAddAuthroShadowRoot() instead of renderMeter(). I'll update the patch and land it.

Shinya Kawanaka

Comment 10 2012-08-13 19:08:33 PDT

Created attachment 158189 [details] Patch for landing

WebKit Review Bot

Comment 11 2012-08-14 00:48:32 PDT

Comment on attachment 158189 [details] Patch for landing Clearing flags on attachment: 158189 Committed r125519: <http://trac.webkit.org/changeset/125519>

WebKit Review Bot

Comment 12 2012-08-14 00:48:37 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 13 2012-08-14 01:45:49 PDT

Re-opened since this is blocked by 93945

Shinya Kawanaka

Comment 14 2012-08-14 19:58:23 PDT

Created attachment 158487 [details] Patch for landing

WebKit Review Bot

Comment 15 2012-08-14 21:47:07 PDT

Comment on attachment 158487 [details] Patch for landing Attachment 158487 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13490881 New failing tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html

WebKit Review Bot

Comment 16 2012-08-14 21:47:11 PDT

Created attachment 158499 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Shinya Kawanaka

Comment 17 2012-08-14 23:51:06 PDT

(In reply to comment #15) > (From update of attachment 158487 [details]) > Attachment 158487 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13490881 > > New failing tests: > fast/dom/shadow/shadowdom-for-meter-dynamic.html This test also fails in the previous patch (which is that EWS bot were all green). I think some bug was introduced these days.

Shinya Kawanaka

Comment 18 2012-08-15 00:31:11 PDT

> This test also fails in the previous patch (which is that EWS bot were all green). > I think some bug was introduced these days. Oops... This was false.

Shinya Kawanaka

Comment 19 2012-08-15 00:46:10 PDT

Created attachment 158519 [details] Patch for landing

WebKit Review Bot

Comment 20 2012-08-15 02:37:48 PDT

Comment on attachment 158519 [details] Patch for landing Clearing flags on attachment: 158519 Committed r125659: <http://trac.webkit.org/changeset/125659>

WebKit Review Bot

Comment 21 2012-08-15 02:37:54 PDT

All reviewed patches have been landed. Closing bug.

Brady Eidson

Comment 22 2012-08-15 16:26:00 PDT

4 of these tests fail on Mac bots. See http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125711%20(1920)/results.html for those.

Shinya Kawanaka

Comment 23 2012-08-15 17:59:33 PDT

(In reply to comment #22) > 4 of these tests fail on Mac bots. > > See http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125711%20(1920)/results.html for those. Just rebaselining should be OK.

Note You need to log in before you can comment on or make changes to this bug.