Bug 89669

Summary: Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape function parameters
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89671    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2012-06-21 09:31:01 PDT
The names of a few of the CSSWrapShape class properties are inconsistent with the corresponding CSS shape function parameters: CSSWrapShapeRectangle - left,top should be x, y CSSWrapShapeCircle - left,top should be centerX, centerY CSSWrapShapeEllipse - left,top should be centerX, centerY To precisely match the specification, radiusX,Y should be rx,y and centerX,Y should be cx,y. This change doesn't seem helpful.
Attachments
Patch (18.82 KB, patch)
2012-07-17 08:14 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2012-07-17 08:14:00 PDT
Created attachment 152767 [details] Patch
Dirk Schulze
Comment 2 2012-07-17 08:21:51 PDT
Comment on attachment 152767 [details] Patch LGTM. r+
WebKit Review Bot
Comment 3 2012-07-17 09:55:10 PDT
Comment on attachment 152767 [details] Patch Clearing flags on attachment: 152767 Committed r122848: <http://trac.webkit.org/changeset/122848>
WebKit Review Bot
Comment 4 2012-07-17 09:55:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.