Bug 89668

Summary: Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, cmarcelo, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89671    
Attachments:
Description Flags
Patch
kling: review+, kling: commit-queue-
patch with isShape condition none

Hans Muller
Reported 2012-06-21 09:29:44 PDT
All of the CSS Exclusions properties are handled by the StyleBuilder class, except for shapeInside and shapeOutside. Move the implementation there, without changing the (current) semantics.
Attachments
Patch (5.98 KB, patch)
2012-06-21 10:02 PDT, Hans Muller 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
patch with isShape condition (5.77 KB, patch)
2012-06-26 17:01 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2012-06-21 10:02:48 PDT
Created attachment 148827 [details] Patch
Andreas Kling
Comment 2 2012-06-25 03:40:10 PDT
Comment on attachment 148827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148827&action=review Looks good. r=me with one change: > Source/WebCore/css/StyleBuilder.cpp:1782 > + else > + setValue(styleResolver->style(), primitiveValue->getShapeValue()); The previous version of the code had a check for primitiveValue->isShape(), if we know that this should always be the case, we could put an ASSERT(primitiveValue->isShape()) here.
Bear Travis
Comment 3 2012-06-26 17:01:33 PDT
Created attachment 149636 [details] patch with isShape condition Trying to shepherd this through. Eventually shape-inside / shape-outside will support a URI value referencing SVG content. shape-inside will additionally support the value "shape-outside". http://dev.w3.org/csswg/css3-exclusions/#shape-outside http://dev.w3.org/csswg/css3-exclusions/#shape-inside I added back the "isShape" condition, but did not add the assert, as we will eventually be supporting additional values.
WebKit Review Bot
Comment 4 2012-06-27 10:45:40 PDT
Comment on attachment 149636 [details] patch with isShape condition Clearing flags on attachment: 149636 Committed r121349: <http://trac.webkit.org/changeset/121349>
Bear Travis
Comment 5 2012-06-29 17:41:52 PDT
Closing the bug
Note You need to log in before you can comment on or make changes to this bug.