Bug 88614

Summary:

Use CUSTOM_SCHEME_HANDLER flag rather than REGISTER_PROTOCOL_HANDLER.

Product:

WebKit

Reporter:

Dongwoo Joshua Im (dwim) <dw.im>

Component:

WebCore Misc.

Assignee:

Dongwoo Joshua Im (dwim) <dw.im>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, dglazkov, japhet, jochen, kling, koz, p.jacquemart, rakuco, rniwa, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	gyuyoung.kim: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04	none
Patch	none
Patch	none
Patch	abarth: review-

Dongwoo Joshua Im (dwim)

Reported 2012-06-07 21:34:51 PDT

Now, two new APIs are added into the Custom Scheme Handler spec, and I implemented those functions in WebCore behind the CUSTOM_SCHEME_HANDLER flag. How about use only CUSTOM_SCHEME_HANDLER rather than use both flags? I think I can move 'registerProtocolHandler' function behind the CUSTOM_SCHEME_HANDLER flag.

Attachments
WIP Patch (43.59 KB, application/octet-stream) 2012-06-08 03:16 PDT, Dongwoo Joshua Im (dwim)	no flags	Details
WIP Patch (43.59 KB, patch) 2012-06-08 03:18 PDT, Dongwoo Joshua Im (dwim)	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (494.83 KB, application/zip) 2012-06-08 09:55 PDT, WebKit Review Bot	no flags	Details
Patch (56.67 KB, patch) 2012-06-15 00:28 PDT, Dongwoo Joshua Im (dwim)	no flags	Details Formatted Diff Diff
Patch (56.67 KB, patch) 2012-06-15 00:39 PDT, Dongwoo Joshua Im (dwim)	no flags	Details Formatted Diff Diff
Patch (56.70 KB, patch) 2012-06-15 00:49 PDT, Dongwoo Joshua Im (dwim)	abarth: review-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dongwoo Joshua Im (dwim)

Comment 1 2012-06-08 01:11:27 PDT

If everyone feels ok about this, I will make the patch.

Dongwoo Joshua Im (dwim)

Comment 2 2012-06-08 03:16:36 PDT

Created attachment 146531 [details] WIP Patch Patch would be look like this WIP patch.

Dongwoo Joshua Im (dwim)

Comment 3 2012-06-08 03:18:42 PDT

Created attachment 146532 [details] WIP Patch To make it easy to look at the WIP patch, I upload this as a "patch". I believe one of ews will deny this "WIP" patch.

Gyuyoung Kim

Comment 4 2012-06-08 09:04:34 PDT

Comment on attachment 146532 [details] WIP Patch Attachment 146532 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12921543

WebKit Review Bot

Comment 5 2012-06-08 09:55:27 PDT

Comment on attachment 146532 [details] WIP Patch Attachment 146532 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12922535 New failing tests: fast/dom/register-protocol-handler.html fast/dom/navigator-detached-no-crash.html

WebKit Review Bot

Comment 6 2012-06-08 09:55:32 PDT

Created attachment 146588 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Dongwoo Joshua Im (dwim)

Comment 7 2012-06-15 00:28:14 PDT

Created attachment 147758 [details] Patch

WebKit Review Bot

Comment 8 2012-06-15 00:32:40 PDT

Attachment 147758 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:222: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dongwoo Joshua Im (dwim)

Comment 9 2012-06-15 00:39:56 PDT

Created attachment 147761 [details] Patch

WebKit Review Bot

Comment 10 2012-06-15 00:42:10 PDT

Attachment 147761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dongwoo Joshua Im (dwim)

Comment 11 2012-06-15 00:49:42 PDT

Created attachment 147764 [details] Patch

Adam Barth

Comment 12 2012-06-28 08:07:10 PDT

Comment on attachment 147764 [details] Patch As discussed on webkit-dev, Chromium currently sets these flags to different values. Please don't combine them until everyone sets them to the same value as each other.

Note You need to log in before you can comment on or make changes to this bug.