Bug 87491

Summary: [CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87640    
Attachments:
Description Flags
Patch and test
none
Updated patch and test that actually applies
none
The final version of the patch
none
Patch that's not actually grabbed from browser cache...
none
Patch
none
Patch none

Andrei Bucur
Reported 2012-05-25 04:57:01 PDT
The CSS Regions spec renamed the CSSOM property "overflow" available on the NamedFlow object to "overset". WebKit needs to update the name as well.
Attachments
Patch and test (13.94 KB, patch)
2012-05-28 03:36 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Updated patch and test that actually applies (28.03 KB, patch)
2012-05-28 07:50 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
The final version of the patch (28.03 KB, patch)
2012-05-28 08:10 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch that's not actually grabbed from browser cache... (28.03 KB, patch)
2012-05-28 08:14 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (14.83 KB, patch)
2012-05-28 08:21 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (15.20 KB, patch)
2012-05-29 02:34 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2012-05-28 03:36:23 PDT
Created attachment 144321 [details] Patch and test
Andrei Bucur
Comment 2 2012-05-28 07:50:47 PDT
Created attachment 144359 [details] Updated patch and test that actually applies
Andrei Bucur
Comment 3 2012-05-28 08:10:11 PDT
Created attachment 144363 [details] The final version of the patch
Andrei Bucur
Comment 4 2012-05-28 08:14:07 PDT
Created attachment 144365 [details] Patch that's not actually grabbed from browser cache...
Andrei Bucur
Comment 5 2012-05-28 08:21:31 PDT
Created attachment 144369 [details] Patch
Andrei Bucur
Comment 6 2012-05-28 08:54:32 PDT
The relevant spec info: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow
Andreas Kling
Comment 7 2012-05-28 08:58:18 PDT
Comment on attachment 144369 [details] Patch r=me, but please add the spec link to the ChangeLog, as well as a little blurb saying that this is the correct new property name per the spec.
Andrei Bucur
Comment 8 2012-05-29 02:34:25 PDT
Created attachment 144491 [details] Patch
WebKit Review Bot
Comment 9 2012-05-29 06:40:11 PDT
Comment on attachment 144491 [details] Patch Clearing flags on attachment: 144491 Committed r118767: <http://trac.webkit.org/changeset/118767>
WebKit Review Bot
Comment 10 2012-05-29 06:40:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.