Bug 87268

Summary: [Chromium] Move themeEngine to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-05-23 08:45:30 PDT
[Chromium] Move themeEngine to Platform.h
Attachments
Patch (8.57 KB, patch)
2012-05-23 08:46 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (40.83 KB, patch)
2012-05-23 12:01 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-23 08:46:08 PDT
Created attachment 143575 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-05-23 08:47:41 PDT
This is obviously only half the story; the other half is taking all the paint* functions out of PlatformSupport.cpp/h and calling them directly from ScrollbarThemeChromium*.cpp. That'll be a followup bug.
WebKit Review Bot
Comment 3 2012-05-23 08:48:51 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-05-23 08:57:55 PDT
Comment on attachment 143575 [details] Patch This is fine, but we should move the WebThemeEngine.h files too.
Mark Pilgrim (Google)
Comment 5 2012-05-23 12:01:49 PDT
Created attachment 143610 [details] Patch
Mark Pilgrim (Google)
Comment 6 2012-05-23 12:02:27 PDT
Comment on attachment 143610 [details] Patch Now moves WebThemeEngine files to new subdirectories in Platform/chromium/public/
WebKit Review Bot
Comment 7 2012-05-23 13:42:36 PDT
Comment on attachment 143610 [details] Patch Clearing flags on attachment: 143610 Committed r118237: <http://trac.webkit.org/changeset/118237>
WebKit Review Bot
Comment 8 2012-05-23 13:42:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.