Bug 85757

Summary: [Chromium] Move idbFactory to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
WIP Patch none

Mark Pilgrim (Google)
Reported 2012-05-06 18:51:21 PDT
[Chromium] Move idbFactory to Platform.h
Attachments
Patch (4.04 KB, patch)
2012-05-06 18:52 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
WIP Patch (121.23 KB, patch)
2012-12-18 12:16 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-06 18:52:34 PDT
Created attachment 140448 [details] Patch
Kentaro Hara
Comment 2 2012-05-06 18:55:18 PDT
Comment on attachment 140448 [details] Patch Looks OK.
WebKit Review Bot
Comment 3 2012-05-06 18:55:42 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kentaro Hara
Comment 4 2012-05-06 18:56:40 PDT
Comment on attachment 140448 [details] Patch Removing r+ since it requires approval from API reviewers.
Build Bot
Comment 5 2012-05-06 19:13:28 PDT
Comment on attachment 140448 [details] Patch Attachment 140448 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12631904
Mark Pilgrim (Google)
Comment 6 2012-05-06 19:22:47 PDT
EWS bot result appears to be flake. Not sure why this patch would cause a segmentation fault.
Adam Barth
Comment 7 2012-05-06 20:29:30 PDT
Comment on attachment 140448 [details] Patch WebIDBFactory is a bit trickier. Specifically, line 58 of WebKitPlatformSupport.h says: class WebIDBFactory; // FIXME: Does this belong in platform? The trouble is that WebIDBFactory::getDatabaseNames depends on WebFrame. Source/Platform isn't allowed to know about Frames or WebFrames, so there's a bit of untangling to do.
Mark Pilgrim (Google)
Comment 8 2012-12-18 12:16:46 PST
Created attachment 179999 [details] WIP Patch
Mark Pilgrim (Google)
Comment 9 2012-12-19 13:37:38 PST
*** This bug has been marked as a duplicate of bug 105460 ***
Note You need to log in before you can comment on or make changes to this bug.