Bug 84175

Summary: Change RenderThemeChromiumSkia paint methods to use pixel snapping
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, jchaffraix, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Emil A Eklund
Reported 2012-04-17 11:42:46 PDT
Change RenderThemeChromiumSkia paint methods to use pixel snapping in preparation for turning on subpixel layout.
Attachments
Patch (8.06 KB, patch)
2012-04-17 12:09 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (8.09 KB, patch)
2012-04-17 16:28 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-04-17 12:09:18 PDT
Created attachment 137578 [details] Patch
WebKit Review Bot
Comment 2 2012-04-17 14:41:26 PDT
Comment on attachment 137578 [details] Patch Attachment 137578 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12425092
Emil A Eklund
Comment 3 2012-04-17 16:28:41 PDT
Created attachment 137630 [details] Patch
Eric Seidel (no email)
Comment 4 2012-04-17 16:59:48 PDT
Comment on attachment 137630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review > Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286 > + LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height())); Don't we normally have "using namespace std;" at the top of cpp files which need min/max?
Emil A Eklund
Comment 5 2012-04-17 17:04:24 PDT
Comment on attachment 137630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137630&action=review >> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:286 >> + LayoutUnit cancelButtonSize = std::min(inputContentBox.width(), std::min(inputContentBox.height(), r.height())); > > Don't we normally have "using namespace std;" at the top of cpp files which need min/max? Normally we do, I wanted to be consistent with the rest of the file though. If you'd like I could change all of it.
Eric Seidel (no email)
Comment 6 2012-04-17 17:13:25 PDT
Yeah, I noticed that after I made the comment, so I just set cq+. It's fine. :)
WebKit Review Bot
Comment 7 2012-04-17 17:31:51 PDT
Comment on attachment 137630 [details] Patch Clearing flags on attachment: 137630 Committed r114471: <http://trac.webkit.org/changeset/114471>
WebKit Review Bot
Comment 8 2012-04-17 17:31:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.