Bug 83497

Created attachment 136298 [details] Patch

Comment on attachment 136298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136298&action=review > Source/WebCore/ChangeLog:10 > + Replace all uses of numeric_limits<LayoutUnit>::min/max with > + MIN_LAYOUT_UNIT and MAX_LAYOUT_UNIT respectively in preparation for the > + switch to subpixel layout. Why does this make the switch easier?

(In reply to comment #2) > (From update of attachment 136298 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136298&action=review > > > Source/WebCore/ChangeLog:10 > > + Replace all uses of numeric_limits<LayoutUnit>::min/max with > > + MIN_LAYOUT_UNIT and MAX_LAYOUT_UNIT respectively in preparation for the > > + switch to subpixel layout. > > Why does this make the switch easier? It allows us to use an abstraction to represent the min/max values for ints (for now) and FractionalLayoutUnits (after the switch). We originally planed to just leave it as is and define numeric_limits for FractionalLayoutUnit but that was shoot down during the initial review of FractionalLayoutUnit.h as it would involve declaring it in the std namespace.

Comment on attachment 136298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136298&action=review >>> Source/WebCore/ChangeLog:10 >>> + switch to subpixel layout. >> >> Why does this make the switch easier? > > It allows us to use an abstraction to represent the min/max values for ints (for now) and FractionalLayoutUnits (after the switch). We originally planed to just leave it as is and define numeric_limits for FractionalLayoutUnit but that was shoot down during the initial review of FractionalLayoutUnit.h as it would involve declaring it in the std namespace. OK. I think I might prefer LayoutUnit::maxValue and LayoutUnit::zeroValue, etc. But I understand that's impractical at this juncture.

(In reply to comment #4) > (From update of attachment 136298 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136298&action=review > > >>> Source/WebCore/ChangeLog:10 > >>> + switch to subpixel layout. > >> > >> Why does this make the switch easier? > > > > It allows us to use an abstraction to represent the min/max values for ints (for now) and FractionalLayoutUnits (after the switch). We originally planed to just leave it as is and define numeric_limits for FractionalLayoutUnit but that was shoot down during the initial review of FractionalLayoutUnit.h as it would involve declaring it in the std namespace. > > OK. > > I think I might prefer LayoutUnit::maxValue and LayoutUnit::zeroValue, etc. But I understand that's impractical at this juncture. We have FractionalLayoutUnit::max and min, and would be happy to add a ::zero. That'll definitely be part of our cleanup pass once we've flipped the switch.

Comment on attachment 136298 [details] Patch Will do a cleanup pass once we've made the switch to make it LayoutUnit::max/min/zero as suggested.

Comment on attachment 136298 [details] Patch Clearing flags on attachment: 136298 Committed r113665: <http://trac.webkit.org/changeset/113665>

All reviewed patches have been landed. Closing bug.