Bug 82522

Summary: [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75780    
Attachments:
Description Flags
Patch
none
Patch for landing none

Noam Rosenthal
Reported 2012-03-28 13:55:24 PDT
[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
Attachments
Patch (11.52 KB, patch)
2012-03-28 15:11 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.01 KB, patch)
2012-04-09 10:15 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-03-28 15:11:45 PDT
Created attachment 134417 [details] Patch
Jocelyn Turcotte
Comment 2 2012-03-29 05:07:09 PDT
Comment on attachment 134417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review LGTM beside one nitpick. > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:73 > + if (!transform().isAffine()) I guess this relates to shouldUseTiledBackingStore? Could you add a comment why it helps?
Kenneth Rohde Christiansen
Comment 3 2012-04-03 07:11:02 PDT
Comment on attachment 134417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:78 > + toWebGraphicsLayer(children()[i])->setShouldUpdateVisibleRect(); hasPendingVisibleRectChange? > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:439 > + if (!m_modified) > + return; I would add a newline after each return statement
Noam Rosenthal
Comment 4 2012-04-09 10:15:57 PDT
Created attachment 136257 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-09 13:57:27 PDT
Comment on attachment 136257 [details] Patch for landing Clearing flags on attachment: 136257 Committed r113615: <http://trac.webkit.org/changeset/113615>
WebKit Review Bot
Comment 6 2012-04-09 13:57:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.