Bug 78852

Summary: Add FractionalLayoutSize for sub-pixel layout
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76571, 78913, 78924    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Emil A Eklund
Reported 2012-02-16 15:38:00 PST
Splitting bug 76571 into one bug/patch per class to make it easier to review.
Attachments
Patch (23.56 KB, patch)
2012-02-16 17:43 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (22.77 KB, patch)
2012-02-17 11:25 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.98 KB, patch)
2012-02-17 12:52 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-02-16 17:43:04 PST
Created attachment 127482 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-16 17:45:38 PST
Comment on attachment 127482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808 > - BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */, > + 144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */, Huh?
Emil A Eklund
Comment 3 2012-02-16 18:09:52 PST
(In reply to comment #2) > (From update of attachment 127482 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127482&action=review > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:19808 > > - BAB771501444CBB400EC4C4C /* FractionalLayoutUnit.h */, > > + 144FCE5114EC79BC000D17A3 /* FractionalLayoutUnit.h */, > > Huh? We got the fingerprint/numeric id wrong. I think the old value is for when the file was named AppUnit.h.
Emil A Eklund
Comment 4 2012-02-17 11:25:20 PST
Created attachment 127617 [details] Patch
Eric Seidel (no email)
Comment 5 2012-02-17 12:01:24 PST
Comment on attachment 127617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127617&action=review > Source/WebCore/platform/graphics/FractionalLayoutSize.h:70 > + m_width = static_cast<int>(static_cast<float>(m_width) * scale); > + m_height = static_cast<int>(static_cast<float>(m_height) * scale); I'm surprised you need the statis_cast<float>. Wont float * int return a float anyway?
Emil A Eklund
Comment 6 2012-02-17 12:26:03 PST
(In reply to comment #5) > I'm surprised you need the statis_cast<float>. Wont float * int return a float anyway? As was I but we get a compiler warning about ambiguity without the cast.
Emil A Eklund
Comment 7 2012-02-17 12:52:50 PST
Created attachment 127632 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-02-17 14:37:56 PST
Comment on attachment 127632 [details] Patch for landing Rejecting attachment 127632 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e/WebCore/platform/graphics/FloatPoint.cpp patching file Source/WebCore/platform/graphics/FloatPoint.h patching file Source/WebCore/platform/graphics/FloatSize.cpp patching file Source/WebCore/platform/graphics/FloatSize.h patching file Source/WebCore/platform/graphics/FractionalLayoutSize.cpp patching file Source/WebCore/platform/graphics/FractionalLayoutSize.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11541519
Emil A Eklund
Comment 9 2012-02-17 15:07:57 PST
Committed r108131: <http://trac.webkit.org/changeset/108131>
Note You need to log in before you can comment on or make changes to this bug.