Bug 73513

Summary: [Blackberry] Upstream BlackBerry porting of plugin framework -- part 2
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, levin+threading, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73185, 73397    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Charles Wei
Reported 2011-11-30 19:44:45 PST
This is continue the work from 78135 to upstream PluginViewPrivateBlackBerry and NPCallbacksBlackBerry.
Attachments
Patch (25.39 KB, patch)
2011-11-30 20:06 PST, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (25.24 KB, patch)
2011-11-30 20:35 PST, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (25.21 KB, patch)
2011-11-30 21:28 PST, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2011-11-30 19:53:58 PST
Should be 73185 instead of 78135 in the last comment.
Charles Wei
Comment 2 2011-11-30 20:06:31 PST
Created attachment 117317 [details] Patch
Charles Wei
Comment 3 2011-11-30 20:35:21 PST
Created attachment 117318 [details] Patch
Antonio Gomes
Comment 4 2011-11-30 20:39:27 PST
Comment on attachment 117318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review > Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:183 > + FrameView* frameView = static_cast<FrameView*>(m_view->parent()); > + > + if (preventIdle == m_idlePrevented) > + return; we could move the early return before the ' frameview = xxx' lines. > Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:325 > + for (int i = 0; (i < PLUGIN_BUFFERS) && success; i++) { unneeded ()
Daniel Bates
Comment 5 2011-11-30 20:42:20 PST
Comment on attachment 117318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review Thanks for the updated patch. In addition to Antonio's suggestions, I have a small nit. > Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.h:22 > +#include <PluginView.h> Nit: This should be: #include "PluginView.h"
Charles Wei
Comment 6 2011-11-30 21:24:50 PST
Thanks, Daniel and Antonio. A new patch is coming to address your comments.
Charles Wei
Comment 7 2011-11-30 21:28:05 PST
Created attachment 117326 [details] Patch
WebKit Review Bot
Comment 8 2011-12-01 11:00:57 PST
Comment on attachment 117326 [details] Patch Clearing flags on attachment: 117326 Committed r101689: <http://trac.webkit.org/changeset/101689>
WebKit Review Bot
Comment 9 2011-12-01 11:01:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.