Bug 73117

Summary: Upstream BlackBerry porting of platform/text
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: TextAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, dbates, staikos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
dbates: review+, dbates: commit-queue-
Patch v2 none

Leo Yang
Reported 2011-11-25 00:07:56 PST
Blackberry's implementation of platform/text.
Attachments
Patch (4.99 KB, patch)
2011-11-25 00:13 PST, Leo Yang 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (4.91 KB, patch)
2011-11-25 00:45 PST, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2011-11-25 00:13:41 PST
Created attachment 116576 [details] Patch
Daniel Bates
Comment 2 2011-11-25 00:19:11 PST
Comment on attachment 116576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review > Source/WebCore/platform/text/blackberry/StringBlackBerry.cpp:29 > +using BlackBerry::WebKit::WebString; > +using BlackBerry::WebKit::WebStringImpl; Nit: These lines are duplicated above.
Leo Yang
Comment 3 2011-11-25 00:20:26 PST
(In reply to comment #2) > (From update of attachment 116576 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review > > > Source/WebCore/platform/text/blackberry/StringBlackBerry.cpp:29 > > +using BlackBerry::WebKit::WebString; > > +using BlackBerry::WebKit::WebStringImpl; > > Nit: These lines are duplicated above. Thanks, will check for it.
Daniel Bates
Comment 4 2011-11-25 00:20:33 PST
Comment on attachment 116576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review > Source/WebCore/ChangeLog:3 > + Upstream blackberry porting of platform/text blackberry => BlackBerry
Leo Yang
Comment 5 2011-11-25 00:26:33 PST
After fix your comments, I'll check in directly.
Leo Yang
Comment 6 2011-11-25 00:45:13 PST
Created attachment 116580 [details] Patch v2 My svn update is still going, using cq...
WebKit Review Bot
Comment 7 2011-11-25 02:07:12 PST
Comment on attachment 116580 [details] Patch v2 Clearing flags on attachment: 116580 Committed r101159: <http://trac.webkit.org/changeset/101159>
WebKit Review Bot
Comment 8 2011-11-25 02:07:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.