Bug 70011

Summary: script-src * should allow all URLs
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 70245    
Bug Blocks: 53572    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-10-13 02:40:47 PDT
script-src * should allow all URLs
Attachments
Patch (4.86 KB, patch)
2011-10-13 02:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-13 02:50:44 PDT
Created attachment 110816 [details] Patch
Eric Seidel (no email)
Comment 2 2011-10-13 02:53:17 PDT
Comment on attachment 110816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110816&action=review OK. > Source/WebCore/page/ContentSecurityPolicy.cpp:273 > + if (end - begin == 1 && *begin == '*') { It seems like you should have a local length = end - begin? Or do you move begin?
Adam Barth
Comment 3 2011-10-13 02:54:24 PDT
Comment on attachment 110816 [details] Patch Yeah, begin and end get moved around a lot in this function. I'd prefer not to have a length variable because I'd worry it would get out of sync.
WebKit Review Bot
Comment 4 2011-10-13 03:15:48 PDT
Comment on attachment 110816 [details] Patch Clearing flags on attachment: 110816 Committed r97360: <http://trac.webkit.org/changeset/97360>
WebKit Review Bot
Comment 5 2011-10-13 03:15:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.