Bug 66305

Summary: [Chromium] GraphicsContext3D should allow its hostWindow to be NULL
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jamesr, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66251    
Attachments:
Description Flags
Patch
none
Patch
none
fixes clipping weirdness none

Stephen White
Reported 2011-08-16 08:11:35 PDT
GraphicsContext3D should allow its hostWindow to be NULL
Attachments
Patch (2.98 KB, patch)
2011-08-16 08:12 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2011-08-16 08:41 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
fixes clipping weirdness (1.10 MB, patch)
2011-08-16 19:01 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2011-08-16 08:12:11 PDT
Created attachment 104045 [details] Patch
WebKit Review Bot
Comment 2 2011-08-16 08:27:58 PDT
Comment on attachment 104045 [details] Patch Attachment 104045 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9401279
Stephen White
Comment 3 2011-08-16 08:41:39 PDT
Created attachment 104050 [details] Patch Patch leveldatabase DEPS as in Chrome
WebKit Review Bot
Comment 4 2011-08-16 09:53:29 PDT
Comment on attachment 104050 [details] Patch Attachment 104050 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9407269
Stephen White
Comment 5 2011-08-16 10:07:21 PDT
The cr-linux EWS bot compiled successfully the first time, but failed a number of international font layout tests (not sure why). On subsequent runs, it failed to build since the leveldatabase directory became unversioned, presumably because other jobs were run in between. As for the layout test failures, I'm not sure what's going on, since the WebKit canaries are running with ToT and seem fine with it. I think the change is correct, but I'll keep an eye on both the canary and webkit.org bots on landing.
WebKit Review Bot
Comment 6 2011-08-16 10:18:27 PDT
Comment on attachment 104050 [details] Patch Attachment 104050 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9405252
James Robinson
Comment 7 2011-08-16 11:19:22 PDT
Comment on attachment 104050 [details] Patch R=me. Please watch the bots carefully when landing.
Stephen White
Comment 8 2011-08-16 11:23:56 PDT
Committed r93131: <http://trac.webkit.org/changeset/93131>
James Robinson
Comment 9 2011-08-16 19:01:56 PDT
Created attachment 104138 [details] fixes clipping weirdness
Stephen White
Comment 10 2011-08-16 20:24:30 PDT
(In reply to comment #9) > Created an attachment (id=104138) [details] > fixes clipping weirdness Did I mess something up? Or is this uploaded to the wrong bug?
James Robinson
Comment 11 2011-08-16 20:26:00 PDT
Gah fail, I mismerged ChangeLogs and webkit-patch sent this to the wrong bug :(. Sorry...
Note You need to log in before you can comment on or make changes to this bug.