Bug 66156

Summary: Switch RenderBox to to new layout types
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-08-12 12:34:11 PDT
Convert *** to new layout abstraction as a part of the ongoing conversion work.
Attachments
Patch (64.40 KB, patch)
2011-08-12 17:02 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (67.02 KB, patch)
2011-08-12 18:33 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (67.04 KB, patch)
2011-08-15 17:22 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (66.88 KB, patch)
2011-08-17 13:41 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-08-12 17:02:49 PDT
Created attachment 103844 [details] Patch
WebKit Review Bot
Comment 2 2011-08-12 17:33:05 PDT
Comment on attachment 103844 [details] Patch Attachment 103844 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9378061 New failing tests: fast/block/float/overhanging-tall-block.html
Emil A Eklund
Comment 3 2011-08-12 17:37:49 PDT
The test overhanging-tall-block.html seems to be missing expected results for cr-linux. Will investigate before I submit but please go ahead and review.
Emil A Eklund
Comment 4 2011-08-12 17:40:04 PDT
Actually, the output suggests that the failing test is the following rather than the float test. Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Looking into why now.
Emil A Eklund
Comment 5 2011-08-12 18:33:54 PDT
Created attachment 103851 [details] Patch
Emil A Eklund
Comment 6 2011-08-15 17:22:23 PDT
Created attachment 103984 [details] Patch
Eric Seidel (no email)
Comment 7 2011-08-17 11:30:56 PDT
Comment on attachment 103984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103984&action=review > Source/WebCore/rendering/RenderBox.cpp:1151 > + LayoutRect clipRect(location + LayoutSize(borderLeft(), borderTop()), Isn't this borderRect().location? > Source/WebCore/rendering/RenderBox.cpp:1864 > - logicalHeight = h.value(); > + logicalHeight = h.calcFloatValue(0); Why?
Emil A Eklund
Comment 8 2011-08-17 12:34:57 PDT
(In reply to comment #7) > (From update of attachment 103984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103984&action=review > > > Source/WebCore/rendering/RenderBox.cpp:1151 > > + LayoutRect clipRect(location + LayoutSize(borderLeft(), borderTop()), > > Isn't this borderRect().location? No, borderBoxRect.location is in the local coordinate space (i.e. does not include the location offset). > > > Source/WebCore/rendering/RenderBox.cpp:1864 > > - logicalHeight = h.value(); > > + logicalHeight = h.calcFloatValue(0); > > Why? Good catch, reverted.
Emil A Eklund
Comment 9 2011-08-17 13:41:41 PDT
Created attachment 104227 [details] Patch for landing
WebKit Review Bot
Comment 10 2011-08-17 23:37:37 PDT
Comment on attachment 104227 [details] Patch for landing Rejecting attachment 104227 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: . creating empty directory: LayoutTests/platform/chromium-mac-leopard creating empty directory: LayoutTests/platform/chromium-mac/fast/events creating empty directory: LayoutTests/platform/chromium-mac/http/tests/workers creating empty directory: LayoutTests/platform/chromium-mac/storage/domstorage Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9423376
WebKit Review Bot
Comment 11 2011-08-17 23:37:45 PDT
Comment on attachment 104227 [details] Patch for landing Clearing flags on attachment: 104227 Committed r93284: <http://trac.webkit.org/changeset/93284>
WebKit Review Bot
Comment 12 2011-08-17 23:37:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.