Bug 65841

Created attachment 103206 [details] Screen-shot-for-posterity

mac ports load plugins in windowless mode by default, chrome linux/win load them windowed mode by default. Need to add attribute windowPlugin="false" on the <embed> in plugins/mouse-events-fixedpos.html to force windowless plugin mode.

Created attachment 103213 [details] Patch

Add chromium-linux results.

Created attachment 103220 [details] Patch for landing

Comment on attachment 103220 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=103220&action=review Looks fine overall, just a small changelog nit. > LayoutTests/platform/chromium-linux/plugins/mouse-events-fixedpos-expected.txt:1 > +CONSOLE MESSAGE: line 39: PLUGIN: getFocusEvent Nit: Please mention in the ChangeLog how we differ from the Apple Mac port (ie., console messages in Apple Mac don't have line numbers). > LayoutTests/platform/chromium-win/plugins/mouse-events-fixedpos-expected.txt:2 > +CONSOLE MESSAGE: line 39: PLUGIN: mouseDown at (90, 90) Why does windows give different coordinates than mac and linux?

> Why does windows give different coordinates than mac and linux? Because windows DRT uses client-window relative co-ords. We can write a quick test to see this.

Created attachment 103431 [details] test-plugin-click-origin.html

See the test, results within. Place a position:absolute plugin <embed> with top left corner at (100px,100px) and click on the page using DRT. If you click a (99,99), no plugin click is logged. But if you click at (100,100), the plugin click is logged at (0,0) in mac/linux (plugin relative co-ords), but at (100,100) on win (client window relative co-ords). See also the webkit win results: http://trac.webkit.org/browser/trunk/LayoutTests/platform/win/plugins/mouse-events-fixedpos-expected.txt

(In reply to comment #6) > Nit: Please mention in the ChangeLog how we differ from the Apple Mac port (ie., console messages in Apple Mac don't have line numbers). Done.

Created attachment 103433 [details] Patch for landing - update ChangeLog

(In reply to comment #7) > > Why does windows give different coordinates than mac and linux? > > Because windows DRT uses client-window relative co-ords. Is this a difference in DRT or in the plugin? Is it something we should try to make consistent across platforms or is this how NPAPI works?

Comment on attachment 103433 [details] Patch for landing - update ChangeLog Rejecting attachment 103433 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: s-fixedpos-expected.txt patching file LayoutTests/platform/chromium-win/plugins/mouse-events-fixedpos-expected.txt patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 735. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/plugins/mouse-events-fixedpos.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9332843

Created attachment 103517 [details] Patch for landing

Comment on attachment 103517 [details] Patch for landing Clearing flags on attachment: 103517 Committed r92790: <http://trac.webkit.org/changeset/92790>

All reviewed patches have been landed. Closing bug.