Bug 65208

Summary: Switch RenderStyle to to new layout types
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-07-26 14:30:31 PDT
Convert RenderStyle to new layout abstraction.
Attachments
Patch (9.30 KB, patch)
2011-07-26 14:46 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (9.30 KB, patch)
2011-07-27 15:40 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.77 KB, patch)
2011-08-08 13:09 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-07-26 14:46:49 PDT
Created attachment 102055 [details] Patch
Emil A Eklund
Comment 2 2011-07-27 15:40:40 PDT
Created attachment 102199 [details] Patch
Eric Seidel (no email)
Comment 3 2011-08-08 09:34:02 PDT
Comment on attachment 102199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102199&action=review Seems reasonable. > Source/WebCore/rendering/style/RenderStyle.cpp:798 > +static RoundedRect::Radii calcRadiiFor(const BorderData& border, LayoutUnit width, LayoutUnit height) Should this be a layoutsize/layoutpoint?
Emil A Eklund
Comment 4 2011-08-08 13:09:38 PDT
Created attachment 103280 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-08-08 13:49:47 PDT
Comment on attachment 103280 [details] Patch for landing Clearing flags on attachment: 103280 Committed r92631: <http://trac.webkit.org/changeset/92631>
WebKit Review Bot
Comment 6 2011-08-08 13:49:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.