Bug 63214

Created attachment 98290 [details] Patch

Comment on attachment 98290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98290&action=review > LayoutTests/editing/deleting/4845371.html:6 > -runEditingTest(); > +runDumpAsTextEditingTest(); You need to dump editing delegate callbacks.

Created attachment 98301 [details] Patch

Created attachment 98447 [details] Patch

Comment on attachment 98447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98447&action=review > LayoutTests/ChangeLog:8 > + Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents-expected, nit: delete-cell-contents.html ? > LayoutTests/editing/deleting/delete-cell-contents.html:-1 > -<p>This tests for a crasher when deleting contents of a table cell.</p> This is not a feedback, just for asking for myself but... How did you make rename and modification separate change in this single patch? I'd like to know how to do this.

Created attachment 98816 [details] Patch

Comment on attachment 98447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98447&action=review >> LayoutTests/ChangeLog:8 >> + Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents-expected, > > nit: delete-cell-contents.html ? good catch! >> LayoutTests/editing/deleting/delete-cell-contents.html:-1 >> -<p>This tests for a crasher when deleting contents of a table cell.</p> > > This is not a feedback, just for asking for myself but... > How did you make rename and modification separate change in this single patch? > I'd like to know how to do this. My workflow is a little convoluted.. I'm a git-user, but it doesn't like renames. So I perform a git branch and make all of the changes I wish to make other than renames, and then I 'Tools/Scripts/webkit-patch upload'. After that, I move to my parallel SVN tree and 'Tools/Scripts/webkit-patch apply-attachment' with the attachment number, perform only the renames (and update the ChangeLog), and upload the attachment again. There is likely a much more smooth way to work, but this is the pattern I've fallen into when renames come into play.

> My workflow is a little convoluted.. I'm a git-user, but it doesn't like renames. So I perform a git branch and make all of the changes I wish to make other than renames, and then I 'Tools/Scripts/webkit-patch upload'. After that, I move to my parallel SVN tree and 'Tools/Scripts/webkit-patch apply-attachment' with the attachment number, perform only the renames (and update the ChangeLog), and upload the attachment again. There is likely a much more smooth way to work, but this is the pattern I've fallen into when renames come into play. Wow, I didn't know SVG can do this... Thank you for disclosing your magic ;-)

> Wow, I didn't know SVG can do this... Thank you for disclosing your magic ;-) ^^^ SVN

The commit-queue encountered the following flaky tests while processing attachment 98816 [details]: http/tests/media/remove-while-loading.html bug 63524 (authors: annacc@chromium.org, jamesr@chromium.org, sjl@chromium.org, and vrk@chromium.org) The commit-queue is continuing to process your patch.

Comment on attachment 98816 [details] Patch Clearing flags on attachment: 98816 Committed r89918: <http://trac.webkit.org/changeset/89918>

All reviewed patches have been landed. Closing bug.