Bug 61804

Summary: Change InlineBox::paint and its overloaded variants to use IntPoint
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-05-31 13:30:57 PDT
InlineBox::paint has 7 overloaded versions.
Attachments
Patch (23.45 KB, patch)
2011-05-31 14:37 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-31 14:22:53 PDT
Also changing RootInlineBox::paintEllipsisBox since it's basically just a shell around this same paint function.
Levi Weintraub
Comment 2 2011-05-31 14:37:26 PDT
Created attachment 95484 [details] Patch
Levi Weintraub
Comment 3 2011-05-31 14:54:30 PDT
Thanks for the review!
Levi Weintraub
Comment 4 2011-05-31 14:55:45 PDT
Comment on attachment 95484 [details] Patch Clearing flags on attachment: 95484 Committed r87753: <http://trac.webkit.org/changeset/87753>
Levi Weintraub
Comment 5 2011-05-31 14:55:51 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 6 2011-05-31 19:30:35 PDT
Comment on attachment 95484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95484&action=review Looks OK besides that one line. > Source/WebCore/rendering/EllipsisBox.cpp:71 > + adjustedPaintOffset.move(m_x + m_logicalWidth - m_markupBox->x(), > + m_y + style->fontMetrics().ascent() - (m_markupBox->y() + m_markupBox->renderer()->style(m_firstLine)->fontMetrics().ascent())); Wow, this is hard to read.
Note You need to log in before you can comment on or make changes to this bug.