Bug 61739

Summary:

[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals

Product:

WebKit

Reporter:

Caio Marcelo de Oliveira Filho <cmarcelo>

Component:

WebKit Qt

Assignee:

Caio Marcelo de Oliveira Filho <cmarcelo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

38654

Attachments:

Description	Flags
Patch	vestbo: review+, vestbo: commit-queue-
fix tor arne comments	none
same as before	none

Caio Marcelo de Oliveira Filho

Reported 2011-05-30 10:50:08 PDT

[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals

Attachments
Patch (5.90 KB, patch) 2011-05-30 11:01 PDT, Caio Marcelo de Oliveira Filho	vestbo: review+ vestbo: commit-queue-	Details Formatted Diff Diff
fix tor arne comments (7.05 KB, patch) 2011-05-31 12:31 PDT, Caio Marcelo de Oliveira Filho	no flags	Details Formatted Diff Diff
same as before (7.14 KB, patch) 2011-05-31 14:09 PDT, Caio Marcelo de Oliveira Filho	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Caio Marcelo de Oliveira Filho

Comment 1 2011-05-30 11:01:17 PDT

Created attachment 95356 [details] Patch

Tor Arne Vestbø

Comment 2 2011-05-31 07:20:49 PDT

Comment on attachment 95356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95356&action=review lgtm, a few comments: > Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:-9 > - height: 300; width: 600 Don't split this, it just adds to the diff for no reason. > Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml:30 > + firstPageOpened = thisPage; pages.firstPageOpened

Caio Marcelo de Oliveira Filho

Comment 3 2011-05-31 12:31:37 PDT

Created attachment 95461 [details] fix tor arne comments

Caio Marcelo de Oliveira Filho

Comment 4 2011-05-31 14:09:29 PDT

Created attachment 95479 [details] same as before Updated to add Tor Arne as reviewer, and using cq to commit.

WebKit Commit Bot

Comment 5 2011-05-31 21:28:24 PDT

Comment on attachment 95479 [details] same as before Rejecting attachment 95479 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8758076

WebKit Commit Bot

Comment 6 2011-06-01 05:15:01 PDT

The commit-queue encountered the following flaky tests while processing attachment 95479 [details]: http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2011-06-01 05:16:22 PDT

Comment on attachment 95479 [details] same as before Clearing flags on attachment: 95479 Committed r87796: <http://trac.webkit.org/changeset/87796>

WebKit Commit Bot

Comment 8 2011-06-01 05:16:26 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 9 2011-06-01 12:34:19 PDT

Revision r87796 cherry-picked into qtwebkit-2.2 with commit 52da9d6 <http://gitorious.org/webkit/qtwebkit/commit/52da9d6>

Note You need to log in before you can comment on or make changes to this bug.