Bug 61113

Summary: Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch andersca: review+

Carlos Garcia Campos
Reported 2011-05-19 00:04:59 PDT
PluginQuirks::CanShortCircuitSomeNPRuntimeCallsDuringInitialization is only defined for mac.
Attachments
Patch (2.27 KB, patch)
2011-05-19 00:06 PDT, Carlos Garcia Campos 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-05-19 00:06:21 PDT
Created attachment 94048 [details] Patch
Martin Robinson
Comment 2 2011-05-19 04:54:39 PDT
Comment on attachment 94048 [details] Patch Wouldn't it be better to define PluginQuirks::CanShortCircuitSomeNPRuntimeCallsDuringInitialization instead of introducing #ifdefs?
Carlos Garcia Campos
Comment 3 2011-05-19 05:06:55 PDT
(In reply to comment #2) > (From update of attachment 94048 [details]) > Wouldn't it be better to define PluginQuirks::CanShortCircuitSomeNPRuntimeCallsDuringInitialization instead of introducing #ifdefs? I don't know what that quirk is, that's why I filed the bug instead of just fixing the build.
Carlos Garcia Campos
Comment 4 2011-05-19 05:16:14 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 94048 [details] [details]) > > Wouldn't it be better to define PluginQuirks::CanShortCircuitSomeNPRuntimeCallsDuringInitialization instead of introducing #ifdefs? > > I don't know what that quirk is, that's why I filed the bug instead of just fixing the build. According to the changelog, the quirk is mac specific * Shared/Plugins/PluginQuirks.h: Add Mac specific CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk.
Anders Carlsson
Comment 5 2011-05-19 09:42:25 PDT
(In reply to comment #2) > (From update of attachment 94048 [details]) > Wouldn't it be better to define PluginQuirks::CanShortCircuitSomeNPRuntimeCallsDuringInitialization instead of introducing #ifdefs? I'd really like platform-specific quirks to be #ifdeffed out so we know which platforms they apply to.
Carlos Garcia Campos
Comment 6 2011-05-19 09:51:26 PDT
Committed r86848: <http://trac.webkit.org/changeset/86848>
Note You need to log in before you can comment on or make changes to this bug.