Bug 60880

Summary: WebSocket: WebSocketHandshake prints a carriage return to console
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60878    
Attachments:
Description Flags
Patch tkent: review+

Yuta Kitamura
Reported 2011-05-16 04:01:18 PDT
LayoutTest/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line. This caused svn-apply to fail (see bug 60878). This situation happened because of a bug in WebSocketHandshake; it prints a carriage return to console if status line is broken. Let's fix this.
Attachments
Patch (3.99 KB, patch)
2011-05-16 04:25 PDT, Yuta Kitamura 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-05-16 04:25:28 PDT
Created attachment 93634 [details] Patch
Yuta Kitamura
Comment 2 2011-05-16 04:33:14 PDT
Comment on attachment 93634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93634&action=review > LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt:1 > +CONSOLE MESSAGE: line 0: No response code found: ThisWillCauseHandshakeError This hunk removes a carriage return at the end of line. EWS bots do not seem happy about this part, so I may have to commit this patch manually.
Kent Tamura
Comment 3 2011-05-16 18:11:05 PDT
Comment on attachment 93634 [details] Patch ok
Yuta Kitamura
Comment 4 2011-05-17 01:10:11 PDT
Manually committed r86659.
Note You need to log in before you can comment on or make changes to this bug.