Bug 60878

Summary:

WebSocket: Add CLOSING state

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

WebCore Misc.

Assignee:

Yuta Kitamura <yutak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, commit-queue, mjs, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

60880

Bug Blocks:

35721

Attachments:

Description	Flags
Patch	none
Patch v2 (Add expected result for Qt)	none
Ready to commit	none

Yuta Kitamura

Reported 2011-05-16 02:48:59 PDT

This is the first part of implementing WebSocket closing handshake (see bug 35721). Add CLOSING state to WebSocket object. Due to a change of the value of WebSocket.CLOSE, we have to update expected results of tests that dump WebSocket.readyState.

Attachments
Patch (11.52 KB, patch) 2011-05-16 02:57 PDT, Yuta Kitamura	no flags	Details Formatted Diff Diff
Patch v2 (Add expected result for Qt) (12.65 KB, patch) 2011-05-16 04:41 PDT, Yuta Kitamura	no flags	Details Formatted Diff Diff
Ready to commit (12.69 KB, patch) 2011-05-17 01:23 PDT, Yuta Kitamura	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yuta Kitamura

Comment 1 2011-05-16 02:57:31 PDT

Created attachment 93630 [details] Patch

Kent Tamura

Comment 2 2011-05-16 03:01:00 PDT

Comment on attachment 93630 [details] Patch r- because of EWS failures.

Yuta Kitamura

Comment 3 2011-05-16 03:36:10 PDT

The EWS failure is not a fault of this patch. LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply. So, it sounds like another yak to shave...

Kent Tamura

Comment 4 2011-05-16 03:48:27 PDT

(In reply to comment #3) > The EWS failure is not a fault of this patch. > > LayoutTests/http/tests/websocket/tests/handshake-error-expected.txt contains a carriage return in the first line, which (seemingly) confuses svn-apply. I see. Anyway, you need to update LayoutTests/qt/fast/dom/Window/window-properties-expected.txt too.

Yuta Kitamura

Comment 5 2011-05-16 04:41:00 PDT

Created attachment 93635 [details] Patch v2 (Add expected result for Qt)

Kent Tamura

Comment 6 2011-05-16 04:52:59 PDT

Comment on attachment 93635 [details] Patch v2 (Add expected result for Qt) ok

Yuta Kitamura

Comment 7 2011-05-17 01:23:21 PDT

Created attachment 93746 [details] Ready to commit

Yuta Kitamura

Comment 8 2011-05-17 01:25:41 PDT

(In reply to comment #7) > Created an attachment (id=93746) [details] > Ready to commit I'd like to see the results of EWS bots before committing.

WebKit Commit Bot

Comment 9 2011-05-17 20:49:11 PDT

The commit-queue encountered the following flaky tests while processing attachment 93746 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) http/tests/appcache/cyrillic-uri.html bug 61020 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 10 2011-05-17 20:50:47 PDT

Comment on attachment 93746 [details] Ready to commit Clearing flags on attachment: 93746 Committed r86732: <http://trac.webkit.org/changeset/86732>

WebKit Commit Bot

Comment 11 2011-05-17 20:50:53 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.