Bug 60629

Summary: Implement plugin process for UNIX platform
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, eric, kbalazs, sam, sangseok.lim
Priority: P2 Keywords: Gtk, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 57617, 58223, 60546, 60621, 61065    
Attachments:
Description Flags
Patch
none
Updated patch
none
Updated patch andersca: review+, gyuyoung.kim: commit-queue-

Carlos Garcia Campos
Reported 2011-05-11 08:22:10 PDT
Patch attached to bug #57617 contains some parts needed to implement the plugin process that are common to unix platforms.
Attachments
Patch (11.45 KB, patch)
2011-05-11 08:27 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (12.42 KB, patch)
2011-05-13 01:03 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (12.55 KB, patch)
2011-06-06 05:53 PDT, Carlos Garcia Campos 		andersca: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-05-11 08:27:57 PDT
Created attachment 93120 [details] Patch This patch contains the common parts needed to implement the plugin process for unix. It's mostly the same patch written by Balazs Kelemen in bug #57617.
Carlos Garcia Campos
Comment 2 2011-05-13 01:03:25 PDT
Created attachment 93415 [details] Updated patch Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store.
Balazs Kelemen
Comment 3 2011-05-13 08:15:42 PDT
(In reply to comment #2) > Created an attachment (id=93415) [details] > Updated patch > > Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store. It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now?
Carlos Garcia Campos
Comment 4 2011-05-15 23:56:07 PDT
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=93415) [details] [details] > > Updated patch > > > > Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store. > > It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now? Yes, see bug https://bugs.webkit.org/show_bug.cgi?id=60621
Carlos Garcia Campos
Comment 5 2011-05-16 05:33:53 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Created an attachment (id=93415) [details] [details] [details] > > > Updated patch > > > > > > Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store. > > > > It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now? > > Yes, see bug https://bugs.webkit.org/show_bug.cgi?id=60621 Just to clarify, I didn't answer your question, sorry, the changelog text is in conflict with my comment, but the patch is not obsolete, patch attached to bug #60621 allows to send null handles.
Carlos Garcia Campos
Comment 6 2011-06-06 05:53:40 PDT
Created attachment 96081 [details] Updated patch Since r88147 the GTK port uses STREAM sockets, so I've updated the patch to use STREAM sockets in the plugin process too for the GTK port.
Gyuyoung Kim
Comment 7 2011-06-06 08:20:54 PDT
Comment on attachment 96081 [details] Updated patch Attachment 96081 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8766865
Anders Carlsson
Comment 8 2011-07-14 08:18:58 PDT
Comment on attachment 96081 [details] Updated patch Ideally I'd like to see a generic, cross-platform way to send a connection endpoint over another connection. However, this is fine for now!
Carlos Garcia Campos
Comment 9 2011-07-14 10:44:47 PDT
Committed r91013: <http://trac.webkit.org/changeset/91013>
Balazs Kelemen
Comment 10 2011-08-25 01:16:28 PDT
*** Bug 57617 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.