Bug 60435

Summary: [EFL] Replace ewk_view_select_* functions by extending Ewk_Editor_Command enum
Product: WebKit Reporter: Kamil Blank <k.blank>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, gyuyoung.kim, kenneth, leandro, l.slachciak, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch none

Kamil Blank
Reported 2011-05-07 06:49:09 PDT
As a continuation of bug 54439 (https://bugs.webkit.org/show_bug.cgi?id=54439) I'd like to propose patch which replaces existing editor commands functions EAPI Eina_Bool ewk_view_select_none(Evas_Object *o); EAPI Eina_Bool ewk_view_select_all(Evas_Object *o); EAPI Eina_Bool ewk_view_select_paragraph(Evas_Object *o); EAPI Eina_Bool ewk_view_select_sentence(Evas_Object *o); EAPI Eina_Bool ewk_view_select_line(Evas_Object *o); EAPI Eina_Bool ewk_view_select_word(Evas_Object *o); by adding new enums into Ewk_Editor_Command.
Attachments
patch (5.31 KB, patch)
2011-05-07 06:54 PDT, Kamil Blank 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kamil Blank
Comment 1 2011-05-07 06:54:14 PDT
Created attachment 92688 [details] patch
WebKit Commit Bot
Comment 2 2011-05-08 11:50:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 92688 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2011-05-08 11:53:50 PDT
Comment on attachment 92688 [details] patch Clearing flags on attachment: 92688 Committed r86031: <http://trac.webkit.org/changeset/86031>
WebKit Commit Bot
Comment 4 2011-05-08 11:53:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.