Bug 60353

Summary:

REGRESSION(r83256): Validation message for <input type=range> is not rendered

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dominicc

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Bug Depends on:

52920

Bug Blocks:

Attachments:

Description	Flags
work-in-progress	none

Kent Tamura

Reported 2011-05-06 00:58:05 PDT

How to reproduce: 1. Open the following HTML with Google Chrome / Chromium, not Safari: <form action=""> <input type=range id=range> <input type=submit id=submit> </form> <script> document.getElementById('range').setCustomValidity('Foo bar'); </script> 2. Click the submit button Results: Google Chrome 11 shows a validation message with "Foo bar". Google Chrome 12 shows nothing. I confirmed shadow DOM tree for a validation message was correctly created and they were attached.

Attachments
work-in-progress (21.25 KB, patch) 2011-05-12 01:35 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2011-05-06 08:26:40 PDT

Probably https://trac.webkit.org/changeset/83256 made the regression.

Kent Tamura

Comment 2 2011-05-08 19:55:06 PDT

Observation: * The size of -webkit-validation-bubble element is set to 0x0 by style calculation. * If I modify ValidationMessage::buildBubbleTree() as follows, the problem is fixed. ExceptionCode ec = 0; - host->ensureShadowRoot()->appendChild(m_bubble.get(), ec); + host->ensureShadowRoot()->firstChild()->appendChild(m_bubble.get(), ec); RefPtr<HTMLElement> clipper = ElementWithPseudoId::create(doc, "-webkit-validation-bubble-arrow-clipper");

Kent Tamura

Comment 3 2011-05-08 20:45:27 PDT

(In reply to comment #2) > Observation: > * The size of -webkit-validation-bubble element is set to 0x0 by style calculation. > * If I modify ValidationMessage::buildBubbleTree() as follows, the problem is fixed. Ok, I found the root cause. RenderSlider, which is a renderer for a host node, doesn't lay out renderers for their light/shadow children. RenderSlider::layout() doesn't call any layout() for them. I'm not sure how to fix the problem. - Should RenderSlider lay out their children? I think we can do so. But is it a general fix? - Shouldn't we attach a validation message tree to each of form controls?

Kent Tamura

Comment 4 2011-05-12 01:35:05 PDT

Created attachment 93266 [details] work-in-progress

Kent Tamura

Comment 5 2011-05-12 03:22:15 PDT

(In reply to comment #4) > Created an attachment (id=93266) [details] > work-in-progress In this approach, ValidationMessage object should be owned by HTMLFormElement, and HTMLFormElement should provide some functions, which are called by HTMLFormControlElement to control validation messages.

Dimitri Glazkov (Google)

Comment 6 2011-05-12 09:09:15 PDT

(In reply to comment #3) > (In reply to comment #2) > > Observation: > > * The size of -webkit-validation-bubble element is set to 0x0 by style calculation. > > * If I modify ValidationMessage::buildBubbleTree() as follows, the problem is fixed. > > Ok, I found the root cause. > RenderSlider, which is a renderer for a host node, doesn't lay out renderers for their light/shadow children. RenderSlider::layout() doesn't call any layout() for them. > > I'm not sure how to fix the problem. > - Should RenderSlider lay out their children? Yes! It is possible and a "good thing" to do. See bug 52920. > I think we can do so. But is it a general fix? > - Shouldn't we attach a validation message tree to each of form controls? This is also a cool idea. The form validating its controls seems like a logical idea. Will this still work for free-standing elements? Or do they always have a form element associated? I can't remember.

Kent Tamura

Comment 7 2011-05-16 19:00:46 PDT

(In reply to comment #6) > > - Should RenderSlider lay out their children? > > Yes! It is possible and a "good thing" to do. See bug 52920. Oh, it's a nice patch! Do you have a plan to proceed it? > > - Shouldn't we attach a validation message tree to each of form controls? > > This is also a cool idea. The form validating its controls seems like a logical idea. Will this still work for free-standing elements? Or do they always have a form element associated? I can't remember. The interactive validation feature works only for controls associated to a <form>, and we show at most one validation message bubble. So there is no problem. However I'm a little afraid using ShadowContent to render form content makes regressions.

Kent Tamura

Comment 8 2011-06-15 21:31:41 PDT

This was fixed by r88757. Now RenderSlider lays out all of children.

Note You need to log in before you can comment on or make changes to this bug.