Bug 60240

Summary: CSP should block Function constructor
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, ggaren, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 53572    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2011-05-04 19:42:42 PDT
CSP should block Function constructor
Attachments
Patch (12.06 KB, patch)
2011-05-04 20:35 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.84 KB, patch)
2011-05-09 15:21 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-04 20:35:41 PDT
Created attachment 92368 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-06 12:11:06 PDT
Comment on attachment 92368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92368&action=review OK. > Source/JavaScriptCore/runtime/FunctionConstructor.cpp:75 > JSObject* constructFunction(ExecState* exec, JSGlobalObject* globalObject, const ArgList& args, const Identifier& functionName, const UString& sourceURL, int lineNumber) One could also just have added an enum argument to this call.
Adam Barth
Comment 3 2011-05-06 12:53:41 PDT
Thoughts from ggaren and/or sam would be useful. I'll leave this patch up here for a bit in case they'd like to comment.
Geoffrey Garen
Comment 4 2011-05-09 13:48:10 PDT
LGTM.
Adam Barth
Comment 5 2011-05-09 13:51:28 PDT
(In reply to comment #4) > LGTM. Thanks for taking a look.
Adam Barth
Comment 6 2011-05-09 15:21:21 PDT
Created attachment 92863 [details] Patch for landing
WebKit Commit Bot
Comment 7 2011-05-09 16:06:10 PDT
Comment on attachment 92863 [details] Patch for landing Clearing flags on attachment: 92863 Committed r86100: <http://trac.webkit.org/changeset/86100>
WebKit Commit Bot
Comment 8 2011-05-09 16:06:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.