Bug 59272

Summary: cr-linux-ews should run tests
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59269, 59915, 59916, 59918, 59919, 59920, 59923    
Bug Blocks:    
Attachments:
Description Flags
hacks
none
iterating
none
Patch none

WebKit Review Bot
Reported 2011-04-22 20:45:47 PDT
cr-linux-ews should run tests
Attachments
hacks (16.65 KB, patch)
2011-04-22 20:47 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
iterating (19.56 KB, patch)
2011-04-23 15:53 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
Patch (6.66 KB, patch)
2011-05-02 12:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-04-22 20:47:49 PDT
Created attachment 90840 [details] hacks
Eric Seidel (no email)
Comment 2 2011-04-22 20:49:41 PDT
Comment on attachment 90840 [details] hacks View in context: https://bugs.webkit.org/attachment.cgi?id=90840&action=review > Tools/Scripts/webkitpy/common/config/ports.py:276 > + return None They don't pass?
WebKit Review Bot
Comment 3 2011-04-23 15:53:02 PDT
Created attachment 90862 [details] iterating
Adam Barth
Comment 4 2011-05-02 12:58:35 PDT
Created attachment 91960 [details] Patch
WebKit Review Bot
Comment 5 2011-05-02 13:03:55 PDT
Attachment 91960 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 6 2011-05-02 13:08:18 PDT
Comment on attachment 91960 [details] Patch I think it's wrong to work around "14 failing tests" on the bot by upping the failure limit for the commit-queue as well. :( Better would be to have a test_expectations file for this port, no? Otherwise this looks fine.
Adam Barth
Comment 7 2011-05-02 14:43:32 PDT
Comment on attachment 91960 [details] Patch Clearing flags on attachment: 91960 Committed r85524: <http://trac.webkit.org/changeset/85524>
Adam Barth
Comment 8 2011-05-02 14:43:37 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 9 2011-05-02 15:42:55 PDT
I'm running this on one bot currently. If that goes well, I'll expand to the rest.
Note You need to log in before you can comment on or make changes to this bug.