Bug 57546

Summary:

[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus

Product:

WebKit

Reporter:

Yi Shen <max.hong.shen>

Component:

WebKit Qt

Assignee:

Yi Shen <max.hong.shen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, kling, laszlo.gombos

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

Other

Bug Depends on:

Bug Blocks:

50925

Attachments:

Description	Flags
first try	none
remove symbian tag	none

Yi Shen

Reported 2011-03-31 07:14:03 PDT

This test requires to count the paint events for the blinking caret in the input field, however, it fails on symbian because the fullscreen size platform Virtual Keyboard shows up when running this test, which covers the web page, and blocks the repaint for the caret in the input field. One simple solution is to disable the VKB during this test. A patch will be provided soon.

Attachments
first try (1.76 KB, patch) 2011-03-31 07:55 PDT, Yi Shen	no flags	Details Formatted Diff Diff
remove symbian tag (1.65 KB, patch) 2011-04-18 08:22 PDT, Yi Shen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yi Shen

Comment 1 2011-03-31 07:55:18 PDT

Created attachment 87728 [details] first try

Andreas Kling

Comment 2 2011-04-08 11:16:19 PDT

Do we have the same problem on Maemo? And does the fix really need to be Symbian-specific?

Yi Shen

Comment 3 2011-04-08 13:39:14 PDT

(In reply to comment #2) > Do we have the same problem on Maemo? And does the fix really need to be Symbian-specific? Thanks for the comments, Kling. I am not sure whether Maemo has the same problem (I guess it has, since N900 uses FullScreen VKB). The problem is that I am still struggling to setup a Meego/Maemo environment. Once I have the environment, I can work on the fix for Maemo. I am also thinking about creating a separated bug for Maemo, then people who has the env can test/submit a similar patch quickly.

Laszlo Gombos

Comment 4 2011-04-15 14:14:46 PDT

Can we just ignore the guards and Qt underneath would know which platforms have VKB ?

Yi Shen

Comment 5 2011-04-18 08:22:48 PDT

Created attachment 90040 [details] remove symbian tag

Laszlo Gombos

Comment 6 2011-04-18 12:32:45 PDT

Comment on attachment 90040 [details] remove symbian tag r=me.

WebKit Commit Bot

Comment 7 2011-04-18 14:53:45 PDT

The commit-queue encountered the following flaky tests while processing attachment 90040 [details]: storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html bug 58835 storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html bug 58836 The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 8 2011-04-18 14:56:37 PDT

Comment on attachment 90040 [details] remove symbian tag Clearing flags on attachment: 90040 Committed r84189: <http://trac.webkit.org/changeset/84189>

WebKit Commit Bot

Comment 9 2011-04-18 14:56:42 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 10 2011-04-18 16:43:06 PDT

The commit-queue encountered the following flaky tests while processing attachment 90040 [details]: security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch.

Note You need to log in before you can comment on or make changes to this bug.