Bug 57137

For Chromium, this test is also failing on all platforms except WIN DEBUG (it just prints "FAIL"). Strangely, this test passes on WIN DEBUG. I don't know why...

Andy, do you know why this test fails everywhere but SnowLeopard? Having a little more information in this bug would be helpful.

Properly skipped on leopard in r82161.

(In reply to comment #2) > Andy, do you know why this test fails everywhere but SnowLeopard? Having a little more information in this bug would be helpful. I don't have an answer yet, but I'm actively working on it.

Note: it also fails in WebKit2 on Snow Leopard: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82173%20(10104)/plugins/embed-prefers-plugins-for-images-pretty-diff.html I will check in the failing results for mac-wk2 snow-leopard soon.

(In reply to comment #5) > Note: it also fails in WebKit2 on Snow Leopard: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82173%20(10104)/plugins/embed-prefers-plugins-for-images-pretty-diff.html > > I will check in the failing results for mac-wk2 snow-leopard soon. And by me, I mean Andy who will be able to tell if the mac-wk2 or the mac-snowleopard results are picked up.

(In reply to comment #5) > Note: it also fails in WebKit2 on Snow Leopard: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82173%20(10104)/plugins/embed-prefers-plugins-for-images-pretty-diff.html > > I will check in the failing results for mac-wk2 snow-leopard soon. Done in r82182.

Fixed all Apple platforms in <http://trac.webkit.org/changeset/82187>. It's somewhat a mystery to me why it fails on other plugin-supporting platforms.

Skipped on non-Apple platforms in <http://trac.webkit.org/changeset/82188>.

This is still failing (and making the bots red) on SL Release WK2: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82252%20(10139)/results.html

<rdar://problem/9202488>

I can't find a revision on today's waterfall where it's failed (it only goes back to ~1300 at this point), and webkit-patch find-flaky-tests does not identify it as a flaky test over the last 200 revisions. I'm not sure why that test failed in r82252, but it is not consistently red on the bot. I'll keep an eye out for failures though.

All Chromium bots became green after r82187.

(In reply to comment #13) > All Chromium bots became green after r82187. Yay!

(In reply to comment #12) > I can't find a revision on today's waterfall where it's failed (it only goes back to ~1300 at this point), and webkit-patch find-flaky-tests does not identify it as a flaky test over the last 200 revisions. I'm not sure why that test failed in r82252, but it is not consistently red on the bot. I'll keep an eye out for failures though. FYI, there is a much easier way to see old builds described here: <http://trac.webkit.org/wiki/TriagingTestFailures#Findoutwheneachteststartedfailing>. Basically you add ?numbuilds=200 to any builder page.

This is still failing on WebKit2 today: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r82432%20(10189)/plugins/embed-prefers-plugins-for-images-pretty-diff.html I guess I'll check in expected failure results.

Since SnowLeopard WebKit2 is clearly an "Apple platform", I've filed bug 57456 to track it. It sounds like this bug can be closed.

Created attachment 91805 [details] Patch

Re-opening to commit qt/gtk fix.

The commit-queue encountered the following flaky tests while processing attachment 91805 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/appcache/main-resource-hash.html bug 59902 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

Comment on attachment 91805 [details] Patch Clearing flags on attachment: 91805 Committed r86086: <http://trac.webkit.org/changeset/86086>

All reviewed patches have been landed. Closing bug.

http://trac.webkit.org/changeset/86086 might have broken Qt Linux Release The following tests are not passing: plugins/plugin-javascript-access.html

Created attachment 92860 [details] Patch

Re-open to land rebaselined results.

The commit-queue encountered the following flaky tests while processing attachment 92860 [details]: java/lc3/JavaObject/JavaObjectToByte-006.html bug 60333 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

Comment on attachment 92860 [details] Patch Clearing flags on attachment: 92860 Committed r86096: <http://trac.webkit.org/changeset/86096>

All reviewed patches have been landed. Closing bug.

http://trac.webkit.org/changeset/86096 might have broken GTK Linux 64-bit Debug

Reopen, because it still fails on Qt Mac platform: --- /buildbot/snowleopard-qt-release/snowleopard-qt-intel-release/build/layout-test-results/plugins/embed-prefers-plugins-for-images-expected.txt 2011-05-09 14:19:34.000000000 -0700 +++ /buildbot/snowleopard-qt-release/snowleopard-qt-intel-release/build/layout-test-results/plugins/embed-prefers-plugins-for-images-actual.txt 2011-05-09 14:19:34.000000000 -0700 @@ -1,4 +1,4 @@ Test that WebKit will load a plug-in to render an image before rendering it natively. -PASS +FAIL I added it to the qt-mac/Skipped list: http://trac.webkit.org/changeset/86138

This test was removed in http://trac.webkit.org/changeset/190859.