Bug 57083

Summary: [Qt] QNetworkReplyHandler refactoring: redirect signal
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cmarcelo, hausmann, jturcotte, kenneth, kling, menard
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 57075    
Bug Blocks:    
Attachments:
Description Flags
patch none

Luiz Agostini
Reported 2011-03-24 23:13:01 PDT
Creating a new signal name 'redirected' to be sent by QNetworkReplyWrapper to QNetworkReplyHandler. The rule for this signal is that if it is sent then no other signal will be sent. Then redirections may be handled completely in its own. The other methods of QNetworkReplyHandler should not take care of redirections and the flag m_redirected is no longer needed.
Attachments
patch (12.23 KB, patch)
2011-03-24 23:25 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-03-24 23:25:01 PDT
Created attachment 86894 [details] patch please review.
Jocelyn Turcotte
Comment 2 2011-03-28 07:37:35 PDT
- qDebug could be removed in this patch instead of removing it in the cleanup patch. - redirected() and redirect() are doing repeated logic and have confusing name. It would be nice to merge them or to give them more defining names and purpose.
Note You need to log in before you can comment on or make changes to this bug.