Bug 56368

Summary: Asynchronous text checking should check the grammar.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: HTML EditingAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 56085, 73616    
Bug Blocks: 71991    
Attachments:
Description Flags
Patch
none
Patch none

Hajime Morrita
Reported 2011-03-15 02:22:41 PDT
Currently asynchronous text checking by EditorClient::requestCheckingOfString() does only spellchecking, but it should also do a grammar checking.
Attachments
Patch (8.95 KB, patch)
2011-12-12 01:35 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (9.48 KB, patch)
2011-12-12 19:45 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2011-12-12 01:35:08 PST
Created attachment 118750 [details] Patch
Hajime Morrita
Comment 2 2011-12-12 18:16:38 PST
Comment on attachment 118750 [details] Patch Please skip for Leopard. It doesn't implement requestCheckingOfString().
Hajime Morrita
Comment 3 2011-12-12 18:17:58 PST
Comment on attachment 118750 [details] Patch Please skip for Leopard. it doesn't implement requestCheckingOfstring().
Shinya Kawanaka
Comment 4 2011-12-12 19:45:41 PST
Created attachment 118940 [details] Patch
Shinya Kawanaka
Comment 5 2011-12-12 19:46:01 PST
Done. (In reply to comment #3) > (From update of attachment 118750 [details]) > Please skip for Leopard. it doesn't implement requestCheckingOfstring().
WebKit Review Bot
Comment 6 2011-12-13 01:34:14 PST
Comment on attachment 118940 [details] Patch Clearing flags on attachment: 118940 Committed r102662: <http://trac.webkit.org/changeset/102662>
WebKit Review Bot
Comment 7 2011-12-13 01:34:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.