Bug 53811

Summary:

Null deref in DOMURL

Product:

WebKit

Reporter:

Cris Neckar <cdn>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jianli

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Cris Neckar

Reported 2011-02-04 14:03:54 PST

Just fixing a null deref in DOMURL when the script execution context doesn't exist at the time of creation. I'll post a patch in a minute.

Attachments
Patch (3.10 KB, patch) 2011-02-04 15:26 PST, Cris Neckar	no flags	Details Formatted Diff Diff
Patch (3.12 KB, patch) 2011-02-07 16:05 PST, Cris Neckar	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Cris Neckar

Comment 1 2011-02-04 15:26:41 PST

Created attachment 81304 [details] Patch

Jian Li

Comment 2 2011-02-07 15:42:46 PST

Comment on attachment 81304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81304&action=review > Source/WebCore/ChangeLog:5 > + fix null deref in DOMURL Please capitalize the 1st character. > LayoutTests/ChangeLog:9 > + * fast/dom/domurl-script-execution-context-crash.html: Added. Since DOMURL is only used for blob URL, I think we'd better put this new test under fast/files. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:6 > + e.apply(w,['webkitURL']); Please add a space after comma. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:16 > + setTimeout(crash,30); ditto. > LayoutTests/fast/dom/domurl-script-execution-context-crash.html:26 > +e=(w=open()).eval; Please add space before and after 2 "=" operators.

Cris Neckar

Comment 3 2011-02-07 16:05:12 PST

Created attachment 81547 [details] Patch

WebKit Commit Bot

Comment 4 2011-02-07 23:43:36 PST

The commit-queue encountered the following flaky tests while processing attachment 81547 [details]: inspector/debugger-scripts.html bug 53982 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 5 2011-02-07 23:45:01 PST

Comment on attachment 81547 [details] Patch Clearing flags on attachment: 81547 Committed r77914: <http://trac.webkit.org/changeset/77914>

WebKit Commit Bot

Comment 6 2011-02-07 23:45:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.