Bug 50921

Summary: [Chromium] Remove non-client-based Geolocation code
Product: WebKit Reporter: John Knottenbelt <jknotten>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 50562    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

John Knottenbelt
Reported 2010-12-13 06:26:20 PST
Once the client-based Geolocation implementation is being tested by DumpRenderTree and passing, we can remove the old non-client-based code in Chromium's WebKit port.
Attachments
Patch (56.36 KB, patch)
2011-01-06 03:59 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
Patch (56.41 KB, patch)
2011-01-06 09:14 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
Patch (56.61 KB, patch)
2011-01-10 03:16 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Knottenbelt
Comment 1 2011-01-06 03:59:57 PST
Created attachment 78105 [details] Patch
Steve Block
Comment 2 2011-01-06 06:59:17 PST
Comment on attachment 78105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78105&action=review LGTM, but would be good to get sign-off from a Chromium person to confirm that this is the right approach. > WebCore/ChangeLog:8 > + No new tests. (OOPS!) Can't submit with an OOPS. Just say that it's code cleanup and is tested with existing tests.
John Knottenbelt
Comment 3 2011-01-06 09:14:52 PST
Created attachment 78123 [details] Patch
Jeremy Orlow
Comment 4 2011-01-06 09:33:53 PST
Comment on attachment 78123 [details] Patch r=me
WebKit Commit Bot
Comment 5 2011-01-07 04:18:03 PST
The commit-queue encountered the following flaky tests while processing attachment 78123 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-01-07 11:48:57 PST
Comment on attachment 78123 [details] Patch Rejecting attachment 78123 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78123]" exit_code: 1 Last 500 characters of output: //bugs.webkit.org/attachment.cgi?id=78123&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=50921&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 78123 from bug 50921. The diff to Tools/ChangeLog looks wrong. Are you sure your ChangeLog entry is at the top of the file? ERROR: ChangeLog entry in Tools/ChangeLog is not at the top of the file. Updating OpenSource Current branch master is up to date. OK to continue? [y/N]: Full output: http://queues.webkit.org/results/7360035
Eric Seidel (no email)
Comment 7 2011-01-07 12:09:58 PST
Comment on attachment 78123 [details] Patch I think the queue is confused. It hung on this patch due to bug 52072. But I've fixed that now. Still the patch looks fine, so I'm not sure how the ChangeLog diff got bad.
WebKit Commit Bot
Comment 8 2011-01-08 17:05:20 PST
The commit-queue encountered the following flaky tests while processing attachment 78123 [details]: http/tests/canvas/webgl/origin-clean-conformance.html bug 52117 (author: enne@google.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2011-01-08 17:06:21 PST
Comment on attachment 78123 [details] Patch Rejecting attachment 78123 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78123]" exit_code: 1 Last 500 characters of output: directory Updating working directory Processing patch 78123 from bug 50921. ERROR: ChangeLog entry in Tools/ChangeLog is not at the top of the file. Updating OpenSource From git://git.webkit.org/WebKit abea93c..3947a3a master -> origin/master M Source/WebCore/ChangeLog M Source/WebCore/platform/qt/CookieJarQt.cpp r75334 = 3947a3a011e2afbb5e9e6d02abd9b8f13b192373 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/7409053
John Knottenbelt
Comment 10 2011-01-10 03:16:53 PST
Created attachment 78390 [details] Patch
Jeremy Orlow
Comment 11 2011-01-10 03:40:27 PST
Comment on attachment 78390 [details] Patch rubber stamp
Jeremy Orlow
Comment 12 2011-01-10 03:41:59 PST
Comment on attachment 78390 [details] Patch Clearing flags on attachment: 78390 Committed r75367: <http://trac.webkit.org/changeset/75367>
Jeremy Orlow
Comment 13 2011-01-10 03:42:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.