Bug 50715

Summary: webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, kling, mihaip, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
move _check_git_architecture to after SCM.__init__ none

Eric Seidel (no email)
Reported 2010-12-08 14:03:39 PST
webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
Attachments
Patch (3.21 KB, patch)
2010-12-08 14:17 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2010-12-08 14:55 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
move _check_git_architecture to after SCM.__init__ (3.55 KB, patch)
2010-12-08 15:13 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-12-08 14:17:33 PST
Created attachment 75960 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-08 14:22:52 PST
Comment on attachment 75960 [details] Patch Hmm... Nevermind, platform.architecture() is not working as expected. Investigating.
Eric Seidel (no email)
Comment 3 2010-12-08 14:55:23 PST
Created attachment 75974 [details] Patch
Eric Seidel (no email)
Comment 4 2010-12-08 15:13:06 PST
Created attachment 75977 [details] move _check_git_architecture to after SCM.__init__
Mihai Parparita
Comment 5 2010-12-08 15:22:46 PST
Comment on attachment 75977 [details] move _check_git_architecture to after SCM.__init__ View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > WebKitTools/ChangeLog:19 > + This message will print twice during 'webkit-patch upload', You could keep track of whether or not you printed out the message in a static, so that it only shows up once.
Eric Seidel (no email)
Comment 6 2010-12-08 15:46:32 PST
(In reply to comment #5) > (From update of attachment 75977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > > > WebKitTools/ChangeLog:19 > > + This message will print twice during 'webkit-patch upload', > > You could keep track of whether or not you printed out the message in a static, so that it only shows up once. webkit-patch calls out to check-webkit-style (a separate process).
Ojan Vafai
Comment 7 2010-12-09 09:53:06 PST
Comment on attachment 75977 [details] move _check_git_architecture to after SCM.__init__ View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > WebKitTools/ChangeLog:23 > + the code is. I considered writing a test for the log message, but it seemed not worth it. I think testing _check_git_architecture is worthwhile just to ensure that the code actually runs. Don't even need to verify the output. It helps avoid simple programming errors (e.g. typos).
Eric Seidel (no email)
Comment 8 2010-12-09 10:49:46 PST
(In reply to comment #7) > (From update of attachment 75977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > > > WebKitTools/ChangeLog:23 > > + the code is. I considered writing a test for the log message, but it seemed not worth it. > > I think testing _check_git_architecture is worthwhile just to ensure that the code actually runs. Don't even need to verify the output. It helps avoid simple programming errors (e.g. typos). Possible, however having git installed is not required for WebKit. So I could check that it throws an OSError or returns a value?
WebKit Commit Bot
Comment 9 2010-12-14 01:26:10 PST
The commit-queue encountered the following flaky tests while processing attachment 75977 [details]: fast/dom/onerror-img.html bug 51019 fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2010-12-14 01:42:48 PST
The commit-queue encountered the following flaky tests while processing attachment 75977 [details]: http/tests/xmlhttprequest/cross-site-denied-response-sync.html bug 51020 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2010-12-14 01:44:01 PST
Comment on attachment 75977 [details] move _check_git_architecture to after SCM.__init__ Clearing flags on attachment: 75977 Committed r74008: <http://trac.webkit.org/changeset/74008>
WebKit Commit Bot
Comment 12 2010-12-14 01:44:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.