Bug 50375

Summary: nrwt multiprocessing - actually implement messaging
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED WONTFIX    
Severity: Normal CC: eric, hayato, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 50557    
Bug Blocks: 50381    
Attachments:
Description Flags
Patch
none
update to tip of tree
none
Patch
none
Patch none

Dirk Pranke
Reported 2010-12-02 00:15:33 PST
nrwt multiprocessing - actually implement messaging
Attachments
Patch (43.01 KB, patch)
2010-12-02 02:39 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
update to tip of tree (42.55 KB, patch)
2010-12-02 20:10 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (29.22 KB, patch)
2010-12-06 04:27 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (32.86 KB, patch)
2010-12-06 05:32 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-12-02 02:39:13 PST
Created attachment 75361 [details] Patch
Dirk Pranke
Comment 2 2010-12-02 20:10:42 PST
Created attachment 75457 [details] update to tip of tree
Dirk Pranke
Comment 3 2010-12-06 04:27:34 PST
Created attachment 75672 [details] Patch
Dirk Pranke
Comment 4 2010-12-06 04:33:24 PST
Okay, I have attempted to simplify this patch by splitting it in to. The first half has moved into bug 50557, and contains the new implementation of the message_broker (message_broker2) as a standalone module. This patch now just contains the changed need to run_webkit_tests.py and dump_render_tree_thread.py to call the new module. The main aspect of these changes, apart from the actual switch to posting messages, is that the code no longer synchronously does cross-class access from run_webkit_tests to dump_render_tree_thread and vice versa; all access is mediated as: TestRunner <-> ManagerConnection <-> WorkerMessageBroker <-> *WorkerConnection <-> dump_render_tree_thread.Worker In some ways it is unfortunate that there are three objects for this, but there need to be at least two to avoid using multiple inheritance in between *WorkerConnection and Worker, and creating ManagerConnection allows us to have a nice symmetry and very clean APIs. message_broker.py is still in the tree as of this patch, but it can be removed (I'm planning to do so in a later patch once everything subsides, but I can add the deletion to this patch if that makes anything easier).
Dirk Pranke
Comment 5 2010-12-06 05:32:52 PST
Created attachment 75681 [details] Patch
Dirk Pranke
Comment 6 2010-12-14 20:51:26 PST
marking as WONTFIX. Will split up the patches differently.
Note You need to log in before you can comment on or make changes to this bug.