Bug 49861

Summary: Rename WebKitTools to Tools
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, jeffm, maruel, nsylvain
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Rename WebKitTools to Tools and update references simon.fraser: review+

mitz
Reported 2010-11-20 00:13:31 PST
Rename WebKitTools to Tools
Attachments
Rename WebKitTools to Tools and update references (77.94 KB, patch)
2010-11-20 00:25 PST, mitz 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-11-20 00:25:03 PST
Created attachment 74473 [details] Rename WebKitTools to Tools and update references
Simon Fraser (smfr)
Comment 2 2010-11-20 09:24:10 PST
Comment on attachment 74473 [details] Rename WebKitTools to Tools and update references rs=me
Dirk Pranke
Comment 3 2010-11-22 14:26:05 PST
This change looks mostly fine and I think it's a great idea, but it's likely to break stuff outside of the WebKit repo. It will certainly break some wrapper scripts in Chromium that we use to minimize the dependencies of our buildbots on WebKit directory layout. Although it looks like SVN doesn't really support symlinks on windows, did you consider the idea of adding a symlink from WebKitTools -> Tools to at least extend the transition period for other repos on non-Win platforms?
Jeff Miller
Comment 4 2010-12-20 11:46:45 PST
OpenSource/Tools/vcbin/midl.exe needs to be rebuilt as well, since it's checked in and has a hard-coded reference to the old name of this folder (WebKitTools). Looks like the source code in MIDLWrapper.cpp was updated, but not the built tool.
Jeff Miller
Comment 5 2010-12-20 12:52:45 PST
I filed https://bugs.webkit.org/show_bug.cgi?id=51347 to rebuild midl.exe.
mitz
Comment 6 2010-12-20 13:20:56 PST
r74301
Note You need to log in before you can comment on or make changes to this bug.