Bug 48919

Summary: [Web Timing] Rename interfaces
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, fishd, gustavo, simonjam, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 30685, 48922    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tony Gentilcore
Reported 2010-11-03 09:23:31 PDT
Currently Web Timing has 3 interfaces: Performance +- Timing +- Navigation These have just been renamed in the spec to: Performance +- PerformanceTiming +- PerformanceNavigation We should rename WebCore/page/Timing to WebCore/page/PerformanceTiming and WebCore/page/Navigation to WebCore/page/PerformanceNavigation. Details: http://dvcs.w3.org/hg/webperf/rev/5d546ada8927
Attachments
Patch (44.16 KB, patch)
2010-11-08 14:37 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (93.77 KB, patch)
2010-11-08 15:28 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (95.20 KB, patch)
2010-11-08 15:54 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (95.55 KB, patch)
2010-11-09 17:44 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (97.67 KB, patch)
2010-11-11 16:14 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-11-08 14:37:29 PST
Created attachment 73288 [details] Patch
Tony Gentilcore
Comment 2 2010-11-08 14:41:14 PST
This looks correct to me. Dimitri might be able to r+.
WebKit Review Bot
Comment 3 2010-11-08 14:48:31 PST
Attachment 73288 [details] did not build on gtk: Build output: http://queues.webkit.org/results/5559041
Early Warning System Bot
Comment 4 2010-11-08 14:50:24 PST
Attachment 73288 [details] did not build on qt: Build output: http://queues.webkit.org/results/5548035
James Simonsen
Comment 5 2010-11-08 15:28:02 PST
Created attachment 73293 [details] Patch Manually created patch. webkit-patch ignored the renamed files.
Early Warning System Bot
Comment 6 2010-11-08 15:36:10 PST
Attachment 73293 [details] did not build on qt: Build output: http://queues.webkit.org/results/5529040
James Simonsen
Comment 7 2010-11-08 15:54:59 PST
Created attachment 73299 [details] Patch
James Simonsen
Comment 8 2010-11-09 17:44:56 PST
Created attachment 73448 [details] Patch Merged with other WebTiming changes from yesterday. I think this is ready to go in. I fixed the issues with Qt and GTK and they're both green now.
James Simonsen
Comment 9 2010-11-11 16:14:41 PST
Created attachment 73677 [details] Patch Updated for EFL and Android.
James Simonsen
Comment 10 2010-11-12 13:47:54 PST
This has an LGTM. Can I get an R+? Thanks.
WebKit Commit Bot
Comment 11 2010-11-12 14:51:47 PST
Comment on attachment 73677 [details] Patch Clearing flags on attachment: 73677 Committed r71951: <http://trac.webkit.org/changeset/71951>
WebKit Commit Bot
Comment 12 2010-11-12 14:51:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.