Bug 44278
| Summary: | chromium windows + linux svg tests failing after r65665 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Gregg <johnnyg> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | schenney, zimmermann |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
John Gregg
http://trac.webkit.org/changeset/65665/ caused some regressions in chromium layout tests on windows and linux
svg/batik/paints/patternRegions-positioned-objects.svg = IMAGE+TEXT
svg/custom/pattern-incorrect-tiling.svg = IMAGE+TEXT
svg/transforms/text-with-mask-with-svg-transform.svg = IMAGE+TEXT
svg/batik/paints/patternRegions.svg = IMAGE
svg/custom/js-late-pattern-and-object-creation.svg = IMAGE
svg/custom/js-late-pattern-creation.svg = IMAGE
svg/custom/non-scaling-stroke.svg = IMAGE
svg/custom/pattern-no-pixelation.svg = IMAGE
svg/custom/stroked-pattern.svg = IMAGE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
John Gregg
Committed r65687: <http://trac.webkit.org/changeset/65687>
John Gregg
that patch was just the failing test expectations. bug isn't fixed yet
Nikolas Zimmermann
(In reply to comment #2)
> that patch was just the failing test expectations. bug isn't fixed yet
Hi John,
can you point me to the failing test results? I need to have a look at them.
John Gregg
Sure, this page should contain show you all the expected results and the actual ones. Let me know if you can't access it or find the information you need.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=svg%2Fclip-path%2Fclip-path-pixelation.svg%2Csvg%2Fbatik%2Ftext%2FtextProperties.svg%2Csvg%2Fclip-path%2Fclip-path-childs-clipped.svg
I'm not an SVG expert, and some of these probably just need new baselines, but i'm pretty sure that at least
svg/transforms/text-with-mask-with-svg-transform.svg
svg/custom/stroked-pattern.svg
are wrong.
Thanks!
Nikolas Zimmermann
(In reply to comment #4)
> svg/transforms/text-with-mask-with-svg-transform.svg
Bug 41428 will contain a speculative fix for masks, please try afterwards.
> svg/custom/stroked-pattern.svg
This result looks correct, the comment in the test is wrong, I should fix it.
The mac baseline and the chromium baselines looks the same to me?
Cheers,
Niko
Stephen Chenney
Committed r114033: <http://trac.webkit.org/changeset/114033>