Bug 40307

Summary: [GTK] DragDataGtk should use DataObjectGtk as the platformDragData
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 30623, 39843    
Attachments:
Description Flags
Patch
none
Patch with Eric's suggestions none

Martin Robinson
Reported 2010-06-08 10:25:28 PDT
DataObjectGtk contains the current state of a drop, so it should be used as the platformDragData in DataObjectGtk.
Attachments
Patch (4.23 KB, patch)
2010-06-08 11:06 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch with Eric's suggestions (4.26 KB, patch)
2010-06-14 17:49 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-06-08 11:06:45 PDT
Created attachment 58161 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-12 19:06:04 PDT
Comment on attachment 58161 [details] Patch WebCore/platform/DragData.h:  + typedef void* DragDataRef; Can't this just be class DataObjectGtk; instead of having to include the header? WebCore/platform/gtk/DragDataGtk.cpp:93 + RefPtr<DocumentFragment> fragment(createFragmentFromMarkup(document, m_platformDragData->markup(), "")); Why store this in a ref ptr at all?
Martin Robinson
Comment 3 2010-06-14 17:49:43 PDT
Created attachment 58735 [details] Patch with Eric's suggestions
Martin Robinson
Comment 4 2010-06-14 17:50:28 PDT
(In reply to comment #2) Thank you for your review. I've incorporated both of your suggestions in a new patch.
Xan Lopez
Comment 5 2010-06-29 05:21:55 PDT
Comment on attachment 58735 [details] Patch with Eric's suggestions Correctomundo.
Martin Robinson
Comment 6 2010-06-29 08:38:24 PDT
Comment on attachment 58735 [details] Patch with Eric's suggestions Clearing flags on attachment: 58735 Committed r62124: <http://trac.webkit.org/changeset/62124>
Martin Robinson
Comment 7 2010-06-29 08:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.