Bug 39401

Summary: [BREWMP] Add EventLoop
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joybro201
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch
none
Revised patch none

Kwang Yul Seo
Reported 2010-05-19 21:13:02 PDT
BREW MP does not have an explicit event loop. Add dummy EventLoop::cycle.
Attachments
Patch (2.36 KB, patch)
2010-05-19 21:14 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Revised patch (2.39 KB, patch)
2010-05-20 00:45 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-05-19 21:14:09 PDT
Created attachment 56557 [details] Patch
Eric Seidel (no email)
Comment 2 2010-05-20 00:32:16 PDT
Comment on attachment 56557 [details] Patch You need to remove the "No new tests (OOPS!)" line and replace it with either tests or reasons for no tests. In this case it's rather obvious that no tests are needed, but that second OOPS! will prevent the bot from being able to land this.
Kwang Yul Seo
Comment 3 2010-05-20 00:45:01 PDT
Created attachment 56570 [details] Revised patch Removed "No new tests. (OOPS!)"
Eric Seidel (no email)
Comment 4 2010-06-02 02:25:39 PDT
Comment on attachment 56557 [details] Patch Cleared Eric Seidel's review+ from obsolete attachment 56557 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Kent Tamura
Comment 5 2010-06-08 23:56:46 PDT
Comment on attachment 56570 [details] Revised patch Looks OK though I don't know why BREW MP needs no explicit event loop.
Kwang Yul Seo
Comment 6 2010-06-08 23:59:00 PDT
(In reply to comment #5) > (From update of attachment 56570 [details]) > Looks OK though I don't know why BREW MP needs no explicit event loop. Thanks. Brew MP does not have have any programmable event loop.
WebKit Commit Bot
Comment 7 2010-06-09 09:59:07 PDT
Comment on attachment 56570 [details] Revised patch Clearing flags on attachment: 56570 Committed r60896: <http://trac.webkit.org/changeset/60896>
WebKit Commit Bot
Comment 8 2010-06-09 09:59:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.