Bug 34194

Summary: [BREWMP] Add conversions between IntPoint and AEEPoint
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Add conversions between IntPoint and AEEPoint
eric: review+
Add conversions between IntPoint and AEEPoint none

Kwang Yul Seo
Reported 2010-01-26 20:07:57 PST
AEEPoint is the data type used by BREWMP to represent a point.
Attachments
Add conversions between IntPoint and AEEPoint (3.40 KB, patch)
2010-01-26 20:12 PST, Kwang Yul Seo 		eric: review+
DetailsFormatted DiffDiff
Add conversions between IntPoint and AEEPoint (3.35 KB, patch)
2010-02-01 16:48 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-26 20:12:12 PST
Created attachment 47486 [details] Add conversions between IntPoint and AEEPoint
Eric Seidel (no email)
Comment 2 2010-02-01 15:40:48 PST
Comment on attachment 47486 [details] Add conversions between IntPoint and AEEPoint 4 : m_x(static_cast<int>(point.x)) 35 , m_y(static_cast<int>(point.y)) Why do you need static_cast? Shouldn't an int16 expand to an int32 without cast? Otherewise looks fine.
Kwang Yul Seo
Comment 3 2010-02-01 16:48:28 PST
Created attachment 47880 [details] Add conversions between IntPoint and AEEPoint Eric, you are right. I removed static_cast from int16 to int32.
WebKit Commit Bot
Comment 4 2010-02-02 02:27:27 PST
Comment on attachment 47880 [details] Add conversions between IntPoint and AEEPoint Clearing flags on attachment: 47880 Committed r54219: <http://trac.webkit.org/changeset/54219>
WebKit Commit Bot
Comment 5 2010-02-02 02:27:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.