Bug 33699

Summary: webkit-patch upload should assign the bug to you
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, levin, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 59061    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Eric Seidel (no email)
Reported 2010-01-14 16:59:58 PST
webkit-patch upload should assign the bug to you
Attachments
Patch (5.73 KB, patch)
2011-04-20 14:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.85 KB, patch)
2011-04-20 14:27 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.66 KB, patch)
2011-04-21 14:27 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.66 KB, patch)
2011-04-21 14:31 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.83 KB, patch)
2011-04-21 14:45 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.89 KB, patch)
2011-04-21 14:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-04-06 16:24:58 PDT
This already works during bug creation, but not when uploading new patches.
Adam Barth
Comment 2 2011-04-20 14:23:01 PDT
Created attachment 90413 [details] Patch
Eric Seidel (no email)
Comment 3 2011-04-20 14:24:30 PDT
Comment on attachment 90413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90413&action=review > Tools/Scripts/webkitpy/tool/steps/postdiff.py:50 > + if self._tool.bugs.fetch_bug(bug_id).is_unassigned(): You should put a FIXME here that we should cache the Bug object.
Adam Barth
Comment 4 2011-04-20 14:27:09 PDT
Created attachment 90414 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-04-20 16:08:53 PDT
Comment on attachment 90414 [details] Patch for landing Clearing flags on attachment: 90414 Committed r84431: <http://trac.webkit.org/changeset/84431>
WebKit Commit Bot
Comment 6 2011-04-20 16:08:58 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2011-04-20 19:26:30 PDT
We need to check whether the assigned_to field exists in the form.
Adam Barth
Comment 8 2011-04-21 14:27:52 PDT
Created attachment 90602 [details] Patch
Adam Barth
Comment 9 2011-04-21 14:31:08 PDT
Created attachment 90604 [details] Patch for landing
Eric Seidel (no email)
Comment 10 2011-04-21 14:41:01 PDT
Comment on attachment 90604 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=90604&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:757 > + log("Cannot find assigned_to control. Do you have the EditBugs privilege?") I would explain to the user what this means, give them action they can take. Something like: Failed to assign bug to you (can't find assigned_to) control. Do you have EditBugs privilages at bugs.webkit.org? You should email webkit-committers@webkit.org or ask in #webkit for someone to add EditBugs to your account to make patch contribution easier, etc.
Adam Barth
Comment 11 2011-04-21 14:45:43 PDT
Created attachment 90606 [details] Patch for landing
Adam Barth
Comment 12 2011-04-21 14:46:23 PDT
Created attachment 90607 [details] Patch for landing
WebKit Commit Bot
Comment 13 2011-04-21 17:25:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 90607 [details]: http/tests/xmlhttprequest/access-control-preflight-credential-sync.html bug 59160 (author: jchaffraix@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2011-04-21 17:34:39 PDT
Comment on attachment 90607 [details] Patch for landing Clearing flags on attachment: 90607 Committed r84575: <http://trac.webkit.org/changeset/84575>
WebKit Commit Bot
Comment 15 2011-04-21 17:34:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.