Bug 32006

Summary: webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, twiz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, webkit.review.bot: commit-queue-

Eric Seidel (no email)
Reported 2009-11-30 21:49:25 PST
bugzilla-tool post-* should refuse to post to closed bugs (or should at least offer to re-open them) We could re-open them automatically... We could also just have it fail and require a --reopen-bug flag or similar.
Attachments
Patch (17.54 KB, patch)
2011-06-28 13:21 PDT, Eric Seidel (no email) 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-06 17:29:23 PST
We just need some sort of "EnsureBugIsOpen" step. Shouldn't be hard to write.
Eric Seidel (no email)
Comment 2 2011-06-28 13:21:43 PDT
Created attachment 98964 [details] Patch
Adam Barth
Comment 3 2011-06-28 15:19:35 PDT
Comment on attachment 98964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98964&action=review I'd add the user confirmation step, but that's a judgement call. > Tools/Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py:41 > + if bug.is_closed(): > + # FIXME: We should probably pass this message in somehow? > + # Right now this step is only used before PostDiff steps, so this is OK. > + self._tool.bugs.reopen_bug(bug.id(), "Reopening to attach new patch.") It sucks that bugzilla needs you to spam a bug in order to re-open it. Why not ask the user to confirm before doing this?
Eric Seidel (no email)
Comment 4 2011-06-28 15:23:39 PDT
I'm happy to ask the user to confirm, or ask the user for a message. Either change is very easy to make.
Eric Seidel (no email)
Comment 5 2011-12-01 11:08:44 PST
Comment on attachment 98964 [details] Patch Dammit reviewers not setting cq+ on my patches. I can't believe I wrote a patch for this 6 months ago and forget about it. :p I really doubt this still applies.
WebKit Review Bot
Comment 6 2011-12-01 12:04:29 PST
Comment on attachment 98964 [details] Patch Rejecting attachment 98964 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: arechangelog.py Hunk #1 succeeded at 63 (offset -1 lines). patching file Tools/Scripts/webkitpy/tool/steps/steps_unittest.py Hunk #2 FAILED at 57. 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/tool/steps/steps_unittest.py.rej patching file Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py Hunk #1 succeeded at 43 with fuzz 2. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10696732
Eric Seidel (no email)
Comment 7 2011-12-02 11:10:40 PST
Committed r101834: <http://trac.webkit.org/changeset/101834>
Note You need to log in before you can comment on or make changes to this bug.