Bug 29179

Summary: Geolocation LayoutTests should use an HTML template
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hamaji, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 27944, 28276    
Attachments:
Description Flags
Patch 1 for bug 29179 none

Steve Block
Reported 2009-09-11 04:55:35 PDT
Currently, most Geolocation LayoutTests use custom HTML wrappers. This is because the standard JS test HTML template includes js-test-post.js, which assumes that the test is synchronous, whereas most Geolocation tests are asynchronous. We should use an HTML template for all Geolocation tests, setting a flag from JS to indicate when the test is asynchronous.
Attachments
Patch 1 for bug 29179 (24.25 KB, patch)
2009-09-29 08:16 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2009-09-29 08:16:49 PDT
Created attachment 40303 [details] Patch 1 for bug 29179
Eric Seidel (no email)
Comment 2 2009-09-29 12:18:50 PDT
Comment on attachment 40303 [details] Patch 1 for bug 29179 I think this looks OK. I think it would also be OK to add something like this to the main js-test-post file. We'd talked about wrapping js-test-post's logic in a function (like finishTest()) and then js-test-post detecting that waitUntilDone() was set (might require adding API to layoutTestController) or using an explicit waitUntilDone() global call which called layoutTestController and also set an isAsynchronous = true flag, and then tests which were async needing to call a specific "notifyDone()" global call which would both call finishTest() and layoutTEstController.notifyDone().
WebKit Commit Bot
Comment 3 2009-09-30 01:55:58 PDT
Comment on attachment 40303 [details] Patch 1 for bug 29179 Clearing flags on attachment: 40303 Committed r48924: <http://trac.webkit.org/changeset/48924>
WebKit Commit Bot
Comment 4 2009-09-30 01:56:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.